Bug 191709 - [ staging ] net-mgmt/routers2-extras
Summary: [ staging ] net-mgmt/routers2-extras
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-07 16:47 UTC by Dan Lukes
Modified: 2014-07-29 00:48 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Lukes 2014-07-07 16:47:09 UTC 
net-mgmt/routers2-extras require staging or will be removed

Fix:
Patch is attached. 

--- net-mgmt/routers2-extras/Makefile.orig	2014-07-07 18:43:26.000000000 +0200
+++ net-mgmt/routers2-extras/Makefile	2014-07-07 18:44:41.000000000 +0200
@@ -21,7 +21,6 @@
 
 NO_BUILD=	YES
 
-NO_STAGE=	yes
 post-patch:
 	for file in buildwan.pl cfgmaker_host.pl 95.pl ; do \
 		${REINPLACE_CMD} -e 's|%%PERL%%|${PERL}|' ${WRKSRC}/$$file; \
@@ -31,11 +30,11 @@
 	done
 
 do-install:
-		${MKDIR} -m 755 ${PREFIX}/www/routers2/extras
+		${MKDIR} -m 755 ${STAGEDIR}${PREFIX}/www/routers2/extras
 .if !defined(NOPORTDOCS)
-		${MKDIR} -m 755 ${DOCSDIR}
+		${MKDIR} -m 755 ${STAGEDIR}${DOCSDIR}
 		for file in README *.txt; do \
-			${INSTALL_DATA} ${WRKSRC}/$$file ${DOCSDIR}; \
+			${INSTALL_DATA} ${WRKSRC}/$$file ${STAGEDIR}${DOCSDIR}; \
 		done
 .endif
 		for file in buildwan.pl cfgmaker_host.pl check_vmware.pl check_foundry checkagent \
@@ -43,14 +42,14 @@
 			mrtg-pnsclient.pl mrtg-portsinuse.pl rrd-archive-clean.pl \
 			rrd-archive.pl rrdextend.pl \
 			winalert.pl targetnames/targetnames.pl; do \
-			${INSTALL_SCRIPT} ${WRKSRC}/$$file ${PREFIX}/www/routers2/extras; \
+			${INSTALL_SCRIPT} ${WRKSRC}/$$file ${STAGEDIR}${PREFIX}/www/routers2/extras; \
 		done
 		for file in mrtg-nrpe.cfg mrtg-pnsclient.cfg rrd-archive.conf winalert.conf ; do \
-			${INSTALL_DATA} ${WRKSRC}/$$file ${PREFIX}/www/routers2/extras; \
+			${INSTALL_DATA} ${WRKSRC}/$$file ${STAGEDIR}${PREFIX}/www/routers2/extras; \
 		done
-		${MKDIR} -m 755 ${PREFIX}/www/routers2/extras/templates
+		${MKDIR} -m 755 ${STAGEDIR}${PREFIX}/www/routers2/extras/templates
 		for file in mrtg-templates/* ; do \
-			${INSTALL_DATA} ${WRKSRC}/$$file ${PREFIX}/www/routers2/extras/templates; \
+			${INSTALL_DATA} ${WRKSRC}/$$file ${STAGEDIR}${PREFIX}/www/routers2/extras/templates; \
 		done
 
 .include <bsd.port.mk>
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-07-08 01:32:20 UTC 
Notify maintainer.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-07-26 07:34:29 UTC 
maintainer approval not required for staging.

Dan, it's very helpful to resubmit patch as an attachment.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-07-29 00:44:34 UTC 
A commit references this bug:

Author: marino
Date: Tue Jul 29 00:43:42 UTC 2014
New revision: 363281
URL: http://svnweb.freebsd.org/changeset/ports/363281

Log:
  Stage net-mgmt/routers2-extras and cleanup

   * stage support
   * use PORTDOCS (remove from pkg-plist)
   * use DOCS instead of NOPORTDOCS
   * get rid of 5 unnecessary for loops

  PR:		191709
  Submitted by:	Dan Lukes
  Modified++:	marino

Changes:
  head/net-mgmt/routers2-extras/Makefile
  head/net-mgmt/routers2-extras/pkg-plist
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-29 00:48:26 UTC 
I tweaked this one a lot too