Created attachment 144496 [details] p5-Net-RabbitFoot.shar Net::RabbitFoot is an AMQP (Advanced Message Queuing Protocol) client library, that is intended to allow you to interact with AMQP-compliant message brokers/servers such as RabbitMQ in an asynchronous fashion. You can use Net::RabbitFoot to - * Declare and delete exchanges * Declare, delete, bind and unbind queues * Set QoS * Publish, consume, get, ack, recover and reject messages * Select, commit and rollback transactions Net::RabbitFoot is known to work with RabbitMQ versions 2.4.0 and version 0-8 of the AMQP specification. WWW: http://search.cpan.org/dist/Net-RabbitFoot/ (In particular, this module is used for the Perl examples on <http://www.rabbitmq.com/getstarted.html>.)
Can you provide test logs from poudriere or redports or at least the output from "make check-plist" followed by "make stage-qa" ?
If you choose poudriere, make sure you use either "poudriere testport" or "poudriere bulk -t" in order to enable stage-qa checks, thanks!
Created attachment 145218 [details] p5-Net-RabbitFoot.shar Replacement .shar file with the following changes suggested by poudriere: - Add missing @dirrmtry statements for lib/perl5, etc. - Set NO_ARCH= yes.
Created attachment 145219 [details] p5-Net-RabbitFoot-1.03-10.0-amd64.log "poudriere testport" logs for this port on 10.0-RELEASE amd64. I also have logs for 9.3-RELEASE amd64, and the i386 flavors of these releases, if you want them (but I'm guessing they are not necessary since the port is CPU independent as poudriere pointed out).
I'm really happy that the effort wasn't wasted as it resulted in an updated patch. However, this log seems that it's missing the QA tests, which look something like: =========================================================================== ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for directories owned by MTREEs ===> Checking for directories handled by dependencies ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) ====>> Checking for staging violations... done =========================================================================== So that tells me the the "-t" options wasn't used for the poudriere run (or that poudriere testport wasn't used). If I am right, can you run it again with -t option this time?
I really did run "poudriere testport", but since I'm just learning poudriere, I'm sure the missing tests are due to some kind of operator error on my part. Is it possible that I attached the wrong log file? In any case, I will re-run with "poudriere bulk -t" and post the results here. Thanks for your patience!
(In reply to bill.brinzer from comment #6) > I really did run "poudriere testport", but since I'm just learning > poudriere, I'm sure the missing tests are due to some kind of operator error > on my part. Is it possible that I attached the wrong log file? yeah, that's an easy mistake to make and it's changed with different poudriere versions. > In any case, I will re-run with "poudriere bulk -t" and post the results > here. Thanks for your patience! No worries. Sorry about the hoop-jumping but you have to admit it's already paid off. :)
(In reply to bill.brinzer from comment #6) > In any case, I will re-run with "poudriere bulk -t" and post the results > here. Thanks for your patience! poudriere bulk -t -C might be useful -- it removes any built package first. If the package is already built, poudriere won't do anything.
Created attachment 145342 [details] p5-Net-RabbitFoot-1.03.log Thanks! Attached is a log with stage-qa output, from "poudriere bulk -t".
according to log, it seems you are being overly aggressive in removing directories in the PLIST: ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for directories owned by MTREEs ===> Checking for directories handled by dependencies Warning: Possibly owned by dependency: @dirrmtry %%PERL5_MAN3%% Warning: Possibly owned by dependency: @dirrmtry lib/perl5/%%PERL_VER%%/man Warning: Possibly owned by dependency: @dirrmtry lib/perl5/%%PERL_VER%% Warning: Possibly owned by dependency: @dirrmtry %%SITE_PERL%%/Net Warning: Possibly owned by dependency: @dirrmtry %%SITE_PERL%%/auto/share/dist Warning: Possibly owned by dependency: @dirrmtry %%SITE_PERL%%/auto/share Warning: Possibly owned by dependency: @dirrmtry %%SITE_PERL%%/auto Warning: Possibly owned by dependency: @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto Warning: Possibly owned by dependency: @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%% Warning: Possibly owned by dependency: @dirrmtry %%SITE_PERL%% Warning: Possibly owned by dependency: @dirrmtry lib/perl5/site_perl Warning: Possibly owned by dependency: @dirrmtry lib/perl5 ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) ====>> Checking for staging violations... done
OK, thanks. Those are the @dirrmtry lines I added after running poudriere the first time, since it was complaining that I wasn't removing those directories. I got the "stage-qa" output to show up in my logs (both "bulk -t" and "testport") by upgrading from poudriere 3.0.13 to poudriere 3.0.16 (whoops). I am guessing that this changed the warnings as well. I will fix the pkg-plist and post the new shar & logs here.
hmm, strange. The idea is: if the directory exists before your port builds, you shouldn't mention it in the plist because it belongs to a dependency. So that's the standard to judge if it should be in the plist or not.
Created attachment 145357 [details] p5-Net-RabbitFoot.shar New shar file with corrected pkg-plist.
Created attachment 145358 [details] p5-Net-RabbitFoot-1.03.log stage-qa output for attachment #145357 [details].
Sorry about the hassle, but it really makes it easier for everyone. Patch ready!
A commit references this bug: Author: marino Date: Thu Aug 7 13:34:50 UTC 2014 New revision: 364271 URL: http://svnweb.freebsd.org/changeset/ports/364271 Log: Add new port net/p5-Net-RabbitFoot PR: 191713 Submitted by: Bill Brinzer ================================================================ Net::RabbitFoot is an AMQP(Advanced Message Queuing Protocol) client library, that is intended to allow you to interact with AMQP-compliant message brokers/servers such as RabbitMQ in an asynchronous fashion. Changes: head/net/Makefile head/net/p5-Net-RabbitFoot/ head/net/p5-Net-RabbitFoot/Makefile head/net/p5-Net-RabbitFoot/distinfo head/net/p5-Net-RabbitFoot/pkg-descr head/net/p5-Net-RabbitFoot/pkg-plist
Thanks!