Bug 191734 - Patch for p5-DBIx-SearchBuilder
Summary: Patch for p5-DBIx-SearchBuilder
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Sivachenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-08 10:14 UTC by Michelle Sullivan
Modified: 2014-07-24 07:24 UTC (History)
2 users (show)

See Also:

Attachments
p5-DBIx-SearchBuilder patch for performance/case-sensitivity (2.92 KB, patch)
2014-07-08 10:14 UTC, Michelle Sullivan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michelle Sullivan 2014-07-08 10:14:26 UTC 
Created attachment 144512 [details]
p5-DBIx-SearchBuilder patch for performance/case-sensitivity

Patch for an optional patch to be applied to make ->Fields() case sensitive and speed up performance for large databases (ones with lots of schema's, or tables, or both)

This is a modification of my previous patch (mentioned in email to ports@), but goes to fully making it case-sensitive (docs patched as well) as I thought, having it 'half broken' is worse than making it completely broken.

Net result is the fields will be returned case-sensitive and the column names will be case sensitive.  Any applications not using the correct case for the calls or results will break with this patch (but really they shouldn't be case-insensitive results when using a case sensitive DB - any Case-Insensitive databases like MySQL will not be affected by this patch, they will continue to return case insensitive results.)
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2014-07-08 10:49:19 UTC 
Tested, builds fine.
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-07-24 06:02:54 UTC 
A commit references this bug:

Author: demon
Date: Thu Jul 24 06:01:58 UTC 2014
New revision: 362767
URL: http://svnweb.freebsd.org/changeset/ports/362767

Log:
  Add a patch from upstream (1.65_1) to speedup some PostgreSQL queries.
  (I applied version from upstream)

  PR:		191734
  Submitted by:	Michelle Sullivan <michelle@sorbs.net>

Changes:
  head/databases/p5-DBIx-SearchBuilder/Makefile
  head/databases/p5-DBIx-SearchBuilder/files/patch-upstream-1.65_1
Comment 3 Dmitry Sivachenko freebsd_committer freebsd_triage 2014-07-24 07:24:49 UTC 
I committed similar patch from upstream.