Bug 192060 - sysutils/dar will not build with encryption
Summary: sysutils/dar will not build with encryption
Status: Closed Unable to Reproduce
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-23 11:36 UTC by graham
Modified: 2015-03-16 10:17 UTC (History)
3 users (show)

See Also:


Attachments
patch for dar-2.4.14_1 (734 bytes, patch)
2014-09-02 09:03 UTC, Muhammad Moinur Rahman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description graham 2014-07-23 11:36:45 UTC
Even though I enable the "gcrypt" option for the port, during the configure stage, it reports "configure: WARNING: strong encryption support has been disabled by user". I don't understand what's going wrong - it looks like the correct options are being passed to configure from make.

As a workaround, I edited the configure script and removed the test for the option being set. Note: this is not a fix - just a hack to get a build going.

In "configure", change:
  if test "${enable_libgcrypt_linking+set}" = set; then :
to
  if false; then
Comment 1 graham 2014-07-23 12:34:59 UTC
Dar version 2.4.14
Comment 2 Raphael Kubo da Costa freebsd_committer 2014-07-23 20:37:06 UTC
CC'ing maintainer.
Comment 3 Muhammad Moinur Rahman freebsd_committer 2014-07-25 12:30:25 UTC
Will check after 8th August. Am on a vaccation with limited internet access.
Comment 4 Carlo Strub freebsd_committer 2014-09-02 07:49:46 UTC
Any news?
Comment 5 Muhammad Moinur Rahman freebsd_committer 2014-09-02 07:52:10 UTC
Oops. Sorry. Forgot it. Let me check it.
Comment 6 Muhammad Moinur Rahman freebsd_committer 2014-09-02 08:02:23 UTC
John can you confirm whether if we need a revision bump?
(In reply to Muhammad Moinur Rahman from comment #5)
> Oops. Sorry. Forgot it. Let me check it.
Comment 7 Muhammad Moinur Rahman freebsd_committer 2014-09-02 09:03:18 UTC
Created attachment 146670 [details]
patch for dar-2.4.14_1

Poudriere logs:
http://pdr.s.ubze.ro/bulk/latest-per-pkg/dar/2.4.14_1/

Poudriere has been tested with :
OPTIONS_DEFAULT=GCRYPT LZO

No port revision bump as GCRYPT and LZO are not default options.
Comment 8 John Marino freebsd_committer 2014-09-02 14:16:00 UTC
agreed, I think you can get by without a bump.
Comment 9 John Marino freebsd_committer 2014-09-02 14:31:09 UTC
tested patch, moving to patch-ready pool
Comment 10 commit-hook freebsd_committer 2014-09-20 15:52:20 UTC
A commit references this bug:

Author: riggs
Date: Sat Sep 20 15:51:19 UTC 2014
New revision: 368654
URL: http://svnweb.freebsd.org/changeset/ports/368654

Log:
  - Fix build with libgcrypt (non-default OPTION)

  PR:		192060
  Submitted by:	graham@menhennitt.com.au
  Patch by:	5u623l20@gmail.com (maintainer)

Changes:
  head/sysutils/dar/Makefile
Comment 11 graham 2015-01-07 04:09:17 UTC
This is broken again as of commit 376062. My workaround (below) again allows encryption to be included.
Comment 12 Muhammad Moinur Rahman freebsd_committer 2015-01-18 11:26:13 UTC
(In reply to graham from comment #11)
Hi I have checked again with the GCRYPT options enabled and found no anomaly. 

For your reference http://pdr.s.ubze.ro/bulk/latest-per-pkg/dar/2.4.15_1/

root@bofh:/usr/local/poudriere/ports/default/lang/guile2 # cat /usr/local/poudriere/data/logs/bulk/latest-per-pkg/dar/2.4.15_1/* | grep encryp
   Strong encryption support  : YES
   Strong encryption support  : YES
   Strong encryption support  : YES
   Strong encryption support  : YES
   Strong encryption support  : YES
   Strong encryption support  : YES
   Strong encryption support  : YES
   Strong encryption support  : YES
Comment 13 graham 2015-03-16 08:40:57 UTC
Well it still doesn't work for me as at rev 378589 (2.4.17).

% cat /var/db/ports/sysutils_dar/options 
# This file is auto-generated by 'make config'.
# Options for dar-2.4.15_1
_OPTIONS_READ=dar-2.4.15_1
_FILE_COMPLETE_OPTIONS_LIST=DOCS GCRYPT LZO NLS
OPTIONS_FILE_UNSET+=DOCS
OPTIONS_FILE_SET+=GCRYPT
OPTIONS_FILE_UNSET+=LZO
OPTIONS_FILE_SET+=NLS
% make
...
checking bzlib.h usability... yes
checking bzlib.h presence... yes
checking for bzlib.h... yes
configure: WARNING: lzo compression support has been disabled by user
configure: WARNING: strong encryption support has been disabled by user
checking for Extended Attribute support... disabled
checking ext2fs.h availability... nodump flag disabled
checking for getopt() availability... ok
checking for getopt_long() availability... available
checking for inttypes.h... (cached) yes
checking furtive read mode availability... no available
configure: ignoring UPX
checking for pthread_mutex_init in -lpthread... yes
checking for POSIX mutex... yes
checking for backtrace in -lexecinfo... yes
checking execinfo.h usability... yes
checking execinfo.h presence... yes
checking for execinfo.h... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating man/Makefile
config.status: creating src/Makefile
config.status: creating src/libdar/Makefile
config.status: creating src/dar_suite/Makefile
config.status: creating src/testing/Makefile
config.status: creating src/examples/Makefile
config.status: creating doc/Makefile
config.status: creating doc/samples/Makefile
config.status: creating misc/Makefile
config.status: creating doc/mini-howto/Makefile
config.status: creating src/libdar/libdar.pc.tmpl
config.status: creating doc/man/Makefile
config.status: creating src/check/Makefile
config.status: creating po/Makefile.in
config.status: creating config.h
config.status: executing po-directories commands
config.status: creating po/POTFILES
config.status: creating po/Makefile
config.status: executing depfiles commands
config.status: executing libtool commands
config.status: executing hack-libtool commands

--
dar and libdar have been successfully configured with the following parameters:

  LIBDAR parameters:
   Zlib compression (gzip)    : YES
   Libbz2 compression (bzip2) : YES
   Liblzo2 compression (lzo)  : NO
   Strong encryption support  : NO
   Extended Attributes support: NO
   Large files support (> 2GB): YES
   ext2fs NODUMP flag support : NO
   Special allocation scheme  : YES
   Integer size used          : infinint
   Thread safe support        : YES
   Furtive read mode          : NO
   Large directory optim.     : YES

  DAR SUITE command line programs:
   Long options available : YES
   Building examples      : NO
   Building dar_static    : NO
   using upx at install   : NO
   building documentation : NO
...
Comment 14 Muhammad Moinur Rahman freebsd_committer 2015-03-16 10:17:34 UTC
Hi,

Following are advised:
1. Update Ports Tree
2. % rm /var/db/ports/sysutils_dar/options 
   % make config
   % make

It's obvious that somehow the OPTS are not read properly somehow. 
configure: WARNING: strong encryption support has been disabled by user