Bug 192178 - [patch] Missing files in NanoBSD image due to missing trailing / in nanobsd.sh
Summary: [patch] Missing files in NanoBSD image due to missing trailing / in nanobsd.sh
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 10.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Warner Losh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-27 23:59 UTC by Jason Unovitch
Modified: 2019-01-21 09:44 UTC (History)
2 users (show)

See Also:

Attachments
nanobsd.gitignore.issue.patch (831 bytes, patch)
2014-07-27 23:59 UTC, Jason Unovitch 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Unovitch freebsd_committer freebsd_triage 2014-07-27 23:59:25 UTC 
Created attachment 145055 [details]
nanobsd.gitignore.issue.patch

Patch attached for the current 'nanobsd.sh' script on 10.0-STABLE (also applies to 11.0-CURRENT).  Currently the cpio commands skip over copying .gitignore files included in various Ruby Gem packages to the final NanoBSD image.  This results in checksum mismatches when `pkg check -s` is run or in this example below when the '460.pkg-checksum' periodic script installed by pkg runs. This is fixed by addition the trailing / to the two grep lines in nanobsd.sh.

----------------

Checking for packages with mismatched checksums:
pkg: fopen(/usr/local/lib/ruby/gems/1.9/gems/bzip2-ruby-0.2.7/.gitignore): No such file or directory rubygem-bzip2-0.2.7_1: /usr/local/lib/ruby/gems/1.9/gems/bzip2-ruby-0.2.7/.gitignore
pkg: fopen(/usr/local/lib/ruby/gems/1.9/gems/json-1.8.1/.gitignore): No such file or directory rubygem-json-1.8.1: /usr/local/lib/ruby/gems/1.9/gems/json-1.8.1/.gitignore
pkg: fopen(/usr/local/lib/ruby/gems/1.9/gems/json_pure-1.8.1/.gitignore): No such file or directory rubygem-json_pure-1.8.1: /usr/local/lib/ruby/gems/1.9/gems/json_pure-1.8.1/.gitignore
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-07-28 02:00:47 UTC 
A commit references this bug:

Author: imp
Date: Fri Jul 28 01:59:58 UTC 2017
New revision: 321637
URL: https://svnweb.freebsd.org/changeset/base/321637

Log:
  Ensure that ordinary files that happen to start with .git, .hg and
  .cvs into the image.

  This makes .gitignore files in the working tree appear in the final
  tree...

  PR: 192178
  Submitted by: Jason Unovitch
  Sponsored by: Netflix
  MFC After: 3 days

Changes:
  head/tools/tools/nanobsd/defaults.sh
Comment 2 Jason Unovitch freebsd_committer freebsd_triage 2017-11-23 21:22:39 UTC 
Warner this was committed as is, would you like to close this? Or are you planning a bulk sync of other nanobsd.sh that would necessitate setting the mfc-stable1* flags and following up on that?
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2018-05-28 19:49:27 UTC 
batch change:

For bugs that match the following
-  Status Is In progress 
AND
- Untouched since 2018-01-01.
AND
- Affects Base System OR Documentation

DO:

Reset to open status.


Note:
I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.
Comment 4 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-01-21 09:44:18 UTC 
There is a commit referencing this PR, but it's still not closed and has been inactive for some time. Closing the PR as fixed but feel free to re-open it if the issue hasn't been completely resolved.

Thanks