Bug 192244 - [exp-run]: Remove USE_PYTHON dependency for lang/python27, simplify build
Summary: [exp-run]: Remove USE_PYTHON dependency for lang/python27, simplify build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Marcus von Appen
URL: https://phabric.freebsd.org/D488
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-29 17:15 UTC by Marcus von Appen
Modified: 2014-08-02 07:02 UTC (History)
2 users (show)

See Also:
mva: exp-run?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus von Appen freebsd_committer freebsd_triage 2014-07-29 17:15:53 UTC
An exp-run is needed for https://phabric.freebsd.org/D488
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2014-07-29 17:16:30 UTC
Over to portmgr
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2014-07-29 17:48:53 UTC
Take for exp-run
I will combine PR 192242 and PR 192244 in the same exp-run
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2014-07-31 07:51:31 UTC
Exp-run results:
http://package18.nyi.freebsd.org/build.html?mastername=91amd64-default-D410D488&build=2014-07-30_10h05m55s

New failures:
+ {"origin"=>"databases/postgresql84-plpython", "pkgname"=>"postgresql84-plpython-8.4.21_2", "phase"=>"package", "errortype"=>"PLIST"}
+ {"origin"=>"databases/postgresql90-plpython", "pkgname"=>"postgresql90-plpython-9.0.17", "phase"=>"package", "errortype"=>"PLIST"}
+ {"origin"=>"databases/postgresql91-plpython", "pkgname"=>"postgresql91-plpython-9.1.13_2", "phase"=>"package", "errortype"=>"PLIST"}
+ {"origin"=>"databases/postgresql92-plpython", "pkgname"=>"postgresql92-plpython-9.2.8_2", "phase"=>"package", "errortype"=>"PLIST"}
+ {"origin"=>"devel/libhid", "pkgname"=>"libhid-0.2.16_1", "phase"=>"configure", "errortype"=>"configure_error"}
+ {"origin"=>"devel/pypersrc", "pkgname"=>"pypersrc-20120106_1", "phase"=>"build", "errortype"=>"linker_error"}
+ {"origin"=>"lang/pypy3-devel", "pkgname"=>"pypy3-2.1.b1_1", "phase"=>"build", "errortype"=>"???"}

Failure logs:
http://package18.nyi.freebsd.org/data/91amd64-default-D410D488/2014-07-30_10h05m55s/logs/errors/postgresql84-plpython-8.4.21_2.log
http://package18.nyi.freebsd.org/data/91amd64-default-D410D488/2014-07-30_10h05m55s/logs/errors/postgresql90-plpython-9.0.17.log
http://package18.nyi.freebsd.org/data/91amd64-default-D410D488/2014-07-30_10h05m55s/logs/errors/postgresql91-plpython-9.1.13_2.log
http://package18.nyi.freebsd.org/data/91amd64-default-D410D488/2014-07-30_10h05m55s/logs/errors/postgresql92-plpython-9.2.8_2.log
http://package18.nyi.freebsd.org/data/91amd64-default-D410D488/2014-07-30_10h05m55s/logs/errors/libhid-0.2.16_1.log
http://package18.nyi.freebsd.org/data/91amd64-default-D410D488/2014-07-30_10h05m55s/logs/errors/pypersrc-20120106_1.log
http://package18.nyi.freebsd.org/data/91amd64-default-D410D488/2014-07-30_10h05m55s/logs/errors/pypy3-2.1.b1_1.log

For the pypy3-devel failure,  I found this:  https://bitbucket.org/pypy/pypy/issue/1601/assertionerror-mixing-pointer-type-with and https://bitbucket.org/pypy/pypy/commits/4e8538d98f8d
Comment 4 Marcus von Appen freebsd_committer freebsd_triage 2014-07-31 16:44:04 UTC
First rough analysis: 

devel/pypersrc tries to be smarter than Python by fiddling around with linker and inlcude arguments itself, which (in my opinion) is just plain wrong (to be seen in tools/pythonconf.py).
Since we do not link the shared lib into lib/pythonX.X/config anymore (following upstream), the error occurs. That being said, configure.sh needs to be fixed to use python2.7-config instead of that handcrafted mess.

devel/libhid does some weird config queries, including a local patch, which makes things worse by changing static library suffixes to shared ones. Again a problem, where the port assumes the shared lib to be in lib/pythonX.X/config.
PYTHON_LDFLAGS=`...` should be changed to PYTHON_LDFLAGS=`pythonX.X-config --ldflags`.

postgresql and pypy3 are under investigation.
Comment 5 Marcus von Appen freebsd_committer freebsd_triage 2014-07-31 17:12:16 UTC
postgresqlXX-plpython needs to get rid of files/patch-plpython-Makefile
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-08-01 15:06:42 UTC
A commit references this bug:

Author: mva
Date: Fri Aug  1 15:06:17 UTC 2014
New revision: 363713
URL: http://svnweb.freebsd.org/changeset/ports/363713

Log:
  - Use the proper libdir for linking against python, since the symlink to
    libpython.so in config/ will vanish soon

  PR:		192244
  With hat:	python@

Changes:
  head/devel/pypersrc/Makefile
  head/devel/pypersrc/files/
  head/devel/pypersrc/files/patch-tools_pythonconf.py
Comment 7 Antoine Brodin freebsd_committer freebsd_triage 2014-08-01 16:08:59 UTC
2nd exp-run:  with ucs4 and the plpython patches removed: http://package18.nyi.freebsd.org/build.html?mastername=91amd64-default-D410D488&build=2014-07-31_20h12m01s

Only 2 new failures, devel/libhid and devel/pypersrc
(the pypy and the plython are fixed)
Comment 8 Marcus von Appen freebsd_committer freebsd_triage 2014-08-01 17:00:18 UTC
Great, devel/pypersrc was committed already (the patch also works with the "old" port layout). devel/libhid and postgresqlXX-plpython will be committed shortly after lang/python27 and lang/python33 are in.
Comment 9 Marcus von Appen freebsd_committer freebsd_triage 2014-08-02 07:02:41 UTC
Committed