Bug 192309 - sysutils/coreutils fails to install Unknown command `allowcodebreaks'
Summary: sysutils/coreutils fails to install Unknown command `allowcodebreaks'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-01 13:39 UTC by mikhail.rokhin
Modified: 2014-08-04 22:07 UTC (History)
4 users (show)

See Also:


Attachments
patch to sysutils/coreutils/Makefile to avoid recreating coreutils.info (338 bytes, patch)
2014-08-01 19:30 UTC, Martin Birgmeier
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mikhail.rokhin 2014-08-01 13:39:31 UTC
Making install in .
gmake[4]: Entering directory `/usr/ports/sysutils/coreutils/work/coreutils-8.23'
  MAKEINFO doc/coreutils.info
./doc/coreutils.texi:6: warning: unrecognized encoding name `UTF-8'.
./doc/coreutils.texi:6: Unknown command `allowcodebreaks'.
makeinfo: Removing output file `doc/coreutils.info' due to errors; use --force to preserve.
gmake[4]: *** [doc/coreutils.info] Error 1
gmake[4]: Leaving directory `/usr/ports/sysutils/coreutils/work/coreutils-8.23'
gmake[3]: *** [install-recursive] Error 1
gmake[3]: Leaving directory `/usr/ports/sysutils/coreutils/work/coreutils-8.23'
gmake[2]: *** [install] Error 2
gmake[2]: Leaving directory `/usr/ports/sysutils/coreutils/work/coreutils-8.23'
*** Error code 2

Stop.
make[1]: stopped in /usr/ports/sysutils/coreutils
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/coreutils

===>>> make stage failed for sysutils/coreutils
===>>> Aborting update

===>>> Update for sysutils/coreutils failed
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-01 13:50:43 UTC
Notifying maintainer (that didn't take long)
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-01 17:24:11 UTC
Can you provide details on the system ? uname -a ?
Comment 3 Martin Birgmeier 2014-08-01 18:41:46 UTC
I have the same issue on two systems:

FreeBSD v902.xyzzy 9.2-RELEASE-p9 FreeBSD 9.2-RELEASE-p9 #3 r267960M: Sat Jun 28 12:33:55 CEST 2014     root@v902.xyzzy:/usr/obj/.../hal/z/SRC/FreeBSD/releng/9.2/sys/XYZZY_SMP  i386

FreeBSD hal.xyzzy 9.2-RELEASE-p9 FreeBSD 9.2-RELEASE-p9 #3 r267960M: Sat Jun 28 10:15:38 CEST 2014     root@hal.xyzzy:/usr/obj/z/SRC/FreeBSD/releng/9.2/sys/XYZZY_SMP  amd64
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-01 18:42:36 UTC
Kurt, I don't believe we assign non-FreeBSD address as the "assignees".  We only CC the maintainer and set to "needs approval".  When the maintainer writes in a comment "I approve", it's set to "patch-ready" and a freebsd committer needs to be assigned the PR (if not already assigned).

You assigned it to the person that opened the PR.
Comment 5 Martin Birgmeier 2014-08-01 19:06:09 UTC
Compile also fails on 10.0.0 (amd64 and i386):

FreeBSD v904.xyzzy 10.0-RELEASE-p5 FreeBSD 10.0-RELEASE-p5 #0 r267168M: Sat Jun  7 08:11:39 CEST 2014     root@v904.xyzzy:/.../hal/z/OBJ/FreeBSD/amd64/releng/10.0/sys/XYZZY_SMP  amd64

FreeBSD v905.xyzzy 10.0-RELEASE-p5 FreeBSD 10.0-RELEASE-p5 #0 r267168M: Sat Jun  7 09:16:25 CEST 2014     root@v905.xyzzy:/.../hal/z/OBJ/FreeBSD/i386/releng/10.0/sys/XYZZY_SMP  i386
Comment 6 Martin Birgmeier 2014-08-01 19:28:51 UTC
The problem is that during the build process, doc/version.texi is recreated, thereby prompting make (during staging) to recreate coreutils.info (from coreutils.texi and version.texi). But this needs makeinfo from texinfo 5.2, but uses the system's installed makeinfo from texinfo 4.8.

The easiest way out is to reset the timestamp of coreutils.info after building, so that during staging it is not recreated.

See attached patch.
Comment 7 Martin Birgmeier 2014-08-01 19:30:06 UTC
Created attachment 145229 [details]
patch to sysutils/coreutils/Makefile to avoid recreating coreutils.info
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-08-01 19:37:52 UTC
A commit references this bug:

Author: pi
Date: Fri Aug  1 19:36:56 UTC 2014
New revision: 363756
URL: http://svnweb.freebsd.org/changeset/ports/363756

Log:
  sysutils/coreutils: avoid rebuilding WRKSRC/doc/coreutils.info

  PR:		192309
  Submitted by:	Martin Birgmeier <la5lbtyi@aon.at>

Changes:
  head/sysutils/coreutils/Makefile
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-01 19:41:02 UTC
Thanks for the bug report, analysis and fix. Committed.
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-03 09:29:59 UTC
mat@ reports that with NLS=off it fails. Probably needs fixed pkg-plist.
Comment 11 commit-hook freebsd_committer freebsd_triage 2014-08-03 09:40:45 UTC
A commit references this bug:

Author: pi
Date: Sun Aug  3 09:40:07 UTC 2014
New revision: 363863
URL: http://svnweb.freebsd.org/changeset/ports/363863

Log:
  sysutils/coreutils: fix pkg-plist for NLS=off

  PR:		192309
  Submitted by:	mat

Changes:
  head/sysutils/coreutils/pkg-plist
Comment 12 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-04 22:07:36 UTC
If no other issues pop up, that's it for this upgrade.