Bug 192349 - mail/mail-notification 5.4_14 fails to start
Summary: mail/mail-notification 5.4_14 fails to start
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-02 22:11 UTC by Jonathan Chen
Modified: 2014-10-09 21:01 UTC (History)
2 users (show)

See Also:

Attachments
Fixes build without hotmail (759 bytes, patch)
2014-09-23 02:39 UTC, Jonathan Chen 		no flags Details | Diff
patch (1.61 KB, patch)
2014-10-09 10:44 UTC, Kurt Jaeger 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Chen 2014-08-02 22:11:41 UTC 
After the commit removing hotmail support, mail-notification fails to start successfully and issues the error:

"Unable to load image "/usr/local/share/mail-notification/hotmail.png" (Failed to open file '/usr/local/share/mail-notification/hotmail.png': No such file or directory)."

It appears to be embedded in the executable:

10:10am> strings mail-notification | grep hotmail
mn_hotmail_mailbox_properties_get_type
mn_hotmail_mailbox_get_type
mn-hotmail
/usr/local/share/mail-notification/hotmail.png
hotmail.com
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-03 11:41:26 UTC 
notifying maintainer in CC
Comment 2 Jonathan Chen 2014-09-23 02:39:19 UTC 
Created attachment 147584 [details]
Fixes build without hotmail
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2014-10-09 10:44:14 UTC 
Created attachment 148137 [details]
patch

Can you test this patch and whether it works ?

It strips the binary, it depends on gmime26 (newer version) and it
increments the PORTREVISION.
Comment 4 Jonathan Chen 2014-10-09 17:24:19 UTC 
Yes, it works.
Comment 5 mwisnicki+freebsd 2014-10-09 19:18:09 UTC 
Sorry, I don't have time to test this. If someone wants to take maintainership of this port, he is more than welcome.
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2014-10-09 20:36:06 UTC 
Jonathan, would you take over as maintainer ?
Comment 7 Jonathan Chen 2014-10-09 20:42:26 UTC 
I'll give it a go. Yes.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-10-09 21:00:55 UTC 
A commit references this bug:

Author: pi
Date: Thu Oct  9 20:59:56 UTC 2014
New revision: 370559
URL: https://svnweb.freebsd.org/changeset/ports/370559

Log:
  mail/mail-notification: fix issues

  - fix dist url
  - hotmail feature disabled
  - strip binary
  - use gmime26 instead of gmime2
  - bump portrevision
  - change maintainer to submitter

  PR:	192349
  Submitted by:	Jonathan Chen <jonc@chen.org.nz>
  Approved by:	mwisnicki+freebsd@gmail.com (maintainer)

Changes:
  head/mail/mail-notification/Makefile
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2014-10-09 21:01:26 UTC 
Thanks -- you're now the maintainer. Patch committed.