Bug 192380 - ports-mgmt/portlint: needs to report wrong order of categories
Summary: ports-mgmt/portlint: needs to report wrong order of categories
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-04 13:25 UTC by Kurt Jaeger
Modified: 2020-07-17 21:12 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2014-08-04 13:25:32 UTC
As can be seen in

https://svnweb.freebsd.org/ports?view=revision&revision=364000

there's a expected order of categories. portlint should try to check
and report this.
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2014-08-04 13:40:18 UTC
portlint -A does it already
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-04 13:49:13 UTC
If portlint -A does this, what's wrong here ?

# grep CATEG Makefile 
CATEGORIES=     databases math graphics
# portlint -A
looks fine.
# pwd
/usr/home/pi/myp/math/pdal

Ah: this only works if we're in /usr/ports/!

Thanks!
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-04 16:14:16 UTC
TODO-pi: patch for portlint that guesses if outside /usr/ports
Comment 4 Walter Schwarzenfeld 2017-12-31 14:33:43 UTC
I think this one is forgotten to be closed.
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2017-12-31 14:38:24 UTC
portlint still does not flag the wrong sequence of categories if we're running
it outside /usr/ports. That's why it's still open.
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2019-11-01 08:48:44 UTC
(In reply to Kurt Jaeger from comment #5)
While portlint still exhibits this behavior, bsd.sanity.mk checks CATEGORIES
nowadays which makes the portlint check kind of pointless.
Maybe this bug can be closed now.

$ grep CATEGORIES math/pdal/Makefile
CATEGORIES=	databases math graphics
$ make -C math/pdal check-sanity
/!\ pdal-2.0.1: Makefile errors /!\

The first entry in CATEGORIES should be the directory where the port lives

*** Error code 1