Bug 192386 - [patch] devel/git has USES=shebang, but never defined SHEBANG_FILES
Summary: [patch] devel/git has USES=shebang, but never defined SHEBANG_FILES
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-05 00:16 UTC by John Marino
Modified: 2014-08-07 09:24 UTC (History)
0 users

See Also:

Attachments
Patch to Makefile to define shebangfix files to fix perl scripts (668 bytes, patch)
2014-08-05 00:16 UTC, John Marino 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2014-08-05 00:16:32 UTC 
Created attachment 145374 [details]
Patch to Makefile to define shebangfix files to fix perl scripts

It was reported to me that a git script had the wrong shebang for perl.  Upon investigation, it looks like it on the order of 60 files with unfixed shebangs.  devel/git has USES=shebangfix but it looks like it was never used.

The following patch will properly fix all the perl scripts that get installed (and probably a few more).  The ones this doesn't fix don't get installed.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-05 00:17:32 UTC 
Wesley, is this okay to commit?
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-06 14:03:55 UTC 
Actually shebang fixes are covered by the general infrastructure blanket, so I've already gotten approval.  I was just providing a preview/head-ups as a courtesy.

I may get around to committing this in a few hours or tomorrow...
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-08-07 09:24:14 UTC 
A commit references this bug:

Author: marino
Date: Thu Aug  7 09:24:05 UTC 2014
New revision: 364254
URL: http://svnweb.freebsd.org/changeset/ports/364254

Log:
  devel/git: Supply SHEBANG_FILES for shebangfix

  The git port had USES=shebangfix defined but it was not told to fix
  anything.  This patch will fix the shebang on a couple dozen perl scripts.

  PR:		192386
  Submitted by:	marino
  Approved by:	General Blanket (wxs@ in copy)

Changes:
  head/devel/git/Makefile