Bug 192471 - www/sams is working great with php 5.3 why its removed?
Summary: www/sams is working great with php 5.3 why its removed?
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-07 16:15 UTC by Mikhail
Modified: 2014-08-09 12:01 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail 2014-08-07 16:15:36 UTC
Port sams does not depend on legacy php4. It works great with php 5.3 mode Safe_mode = On.
To work correctly with sams php53 must make the following changes to the file /usr/local/etc/php.ini:
safe_mode = On
safe_mode_exec_dir = "/ usr / local / share / sams / bin"
On versions of freebsd below 10 this port is going well and even works with apache 2.4 and mysql 5.5.
But in freeBSD 10, for correct build is necessary to make the following changes to the files /usr/ports/www/sams/work/sams-1.0.5/ logtool.c
/usr/ports/www/sams/work/sams-1.0.5/tools.c
/usr/ports/www/sams/work/sams-1.0.5/redirect.c
/usr/ports/www/sams/work/sams-1.0.5/samsdaemon.c
Change #include <mysql.h> on #include </usr/local/include/mysql/mysql.h>
Then build and install the port sams held successfully and on freebsd 10.
Subsequently, the port works without any errors.
Please, those who can write posposobstvat of an associated patch for www / sams, and return it to the ports tree - help!
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-07 16:59:29 UTC
Because it was marked as PHP4 only, simple as that.  And if I understand you correctly, it works with PHP 5 only after you patched it, which means the marking was correct.

Feel free to resubmit a completely ready to go "sams" for PHP 5 and and mention it's a revival.

Oh, and ports can't be revived without a maintainer, so it needs a maintainer too.
Comment 2 Mikhail 2014-08-07 18:44:53 UTC
No, no patches or changes to work with PHP 5.3 is not necessary.
Absolutely no!
SAMS works fine with php 5.3 "as is."
The patch only need to specify the path to the  mysql.h only for freebsd 10.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-07 18:51:44 UTC
(In reply to Mikhail from comment #0)
> But in freeBSD 10, for correct build is necessary to make the following
> changes to the files /usr/ports/www/sams/work/sams-1.0.5/ logtool.c
> /usr/ports/www/sams/work/sams-1.0.5/tools.c
> /usr/ports/www/sams/work/sams-1.0.5/redirect.c
> /usr/ports/www/sams/work/sams-1.0.5/samsdaemon.c
> Change #include <mysql.h> on #include </usr/local/include/mysql/mysql.h>

1) that's not how I interpret the above
2) There's still no maintainer
3) that FreeBSD 10 thing is a change, so yes, the older port still needed a change

And php5.3 is old, what about 5.4, and 5.5?

We aren't even close to bring sams back based on what you're saying.  I'd have to see Redports x8 tests (4 platforms) and working with latest PHP, and you accept being the maintainer.  Are you willing to do create that port, test it and submit?
Comment 4 Mikhail 2014-08-07 19:59:20 UTC
On PHP 5.5 will not work. Because the difference in the global variables is.
Sams also will not work with squid higher than version 3.1 (again, the difference in the syntax).
But as long as there is in the ports php53 and squid 2.7.9, why not return the sams, which it is currently working correctly with them without any patches?
I'm just starting to learn freebsd, so at this stage it is not able to provide full support for the port as maintaner.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-07 20:20:13 UTC
You're not making a compelling argument.  PHP 5.3 is already on borrowed time; it's original EOL date was March 2013 so it will likely to be removed soon.  

It looks like there are newer version of SAMES, e.g. 2.0.  What was removed was version 1.05.  I would recommend that you create a new SAMS port based on 2.0 which I assume works with the latest PHP.
Comment 6 Mikhail 2014-08-08 04:09:51 UTC
Well, I agree to maintain this port, what should I do next?
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-08 05:54:30 UTC
You are not comprehending what I am telling you.

Submit a new port based on SAMS 2.0 that works with PHP 5.5.  And that assumes SAMS 2.0 isn't also going obsolete as I read in the ports@ mailing list.

We're not going to revive SAMS 1.0.5 for only php 5.3.  It's just not worth it.  You can always maintain a local copy of the old "www/sams" port if you personally really want it.
Comment 8 John Marino freebsd_committer freebsd_triage 2014-08-08 14:35:26 UTC
It looks like m.tsatsenko did this intentionally in bug 189787 so we need to wait and hear what he has to say.  

Steve Wills put it through, so maybe the logic is that xmlto is too heavy not to have an option to disable it, but we're always supposed to install man pages.
Comment 9 John Marino freebsd_committer freebsd_triage 2014-08-08 14:35:59 UTC
(In reply to John Marino from comment #8)
> It looks like m.tsatsenko did this intentionally in bug 189787 so we need to
> wait and hear what he has to say.  
> 
> Steve Wills put it through, so maybe the logic is that xmlto is too heavy
> not to have an option to disable it, but we're always supposed to install
> man pages.

disregard, wrong PR.
Comment 10 John Marino freebsd_committer freebsd_triage 2014-08-09 12:01:34 UTC
submitted was told old port can't be revived as is, a new version that works with PHP 5.5 would need to be introduced as a new maintained port.