Bug 192606 - [ports-mgmt/pkg] Patch fixing the failure to report shlib-to-shlib missing dependencies for 'pkg check -B'
Summary: [ports-mgmt/pkg] Patch fixing the failure to report shlib-to-shlib missing de...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: freebsd-pkg (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-12 06:31 UTC by Yuri Victorovich
Modified: 2014-12-14 19:45 UTC (History)
0 users

See Also:

Attachments
patch (587 bytes, patch)
2014-08-12 06:31 UTC, Yuri Victorovich 		no flags Details | Diff
corrected patch (610 bytes, patch)
2014-08-12 08:41 UTC, Yuri Victorovich 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2014-08-12 06:31:20 UTC 
The function in question 'add_shlibs_to_pkg' tries to avoid adding missing shlib to database, but in the meantime it fails to report the problem to user.

The attached patch fixes the problem.

I am also not sure if return (EPKG_OK) for shared library is correct there. But it was there before, and patch preserves it.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2014-08-12 06:31:50 UTC 
Created attachment 145698 [details]
patch
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2014-08-12 08:41:49 UTC 
Created attachment 145701 [details]
corrected patch
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-12 08:46:49 UTC 
over to maintainer
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2014-12-14 19:45:12 UTC 
Re-post closed on Github
https://github.com/freebsd/pkg/pull/1093#issuecomment-66913361