Created attachment 146213 [details] A patch for japanese/alias-fonts. * Add staging support. * Remove unnecessary BUILD_DEPENDS. * Take maintainership.
Thanks! Do you have any verification available? In order of preference, examples of what I'm looking for are: 1) "poudriere testport" or "poudriere bulk -t" logs 2) Redports or tinderbox logs 3) "make check-plist" followed by "make stage-qa" output (https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html) Also, please run "portlint" and paste the output.
i'll risk it without test logs. It does need revbumping as dependencies changed.
This is exactly why I asked for proof: =========================================================================== ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for directories owned by MTREEs ===> Checking for directories handled by dependencies ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) ====>> Checking for staging violations... done ====>> Error: Filesystem touched during stage (files must install to ${STAGEDIR usr/local/lib/X11/fonts/local/fonts.alias: size (14469, 28894) extra: usr/local/lib/X11/fonts/local/fonts.alias.orig ===> Cleaning for ja-alias-fonts-1.0_9 build of /usr/ports/japanese/alias-fonts ended at Mon Aug 25 09:16:23 CEST 2014 build time: 00:00:09 this port touches the /usr/local before it gets installed, that's illegal.
hmmm, empty pkg-plist, maybe you should just set this to NO_BUILD and let pkg-install do it's thing.
if I replace do-install with "NO_INSTALL=yes", it stages but I get leftovers because of pkg-deinstall creates backup: [Release100-default-job-01] [1/1] Deleting ja-alias-fonts-1.0_9... done =========================================================================== ====>> Checking for extra files and directories ====>> Files or directories left over: lib/X11/fonts/local/fonts.alias.orig ===> Cleaning for ja-alias-fonts-1.0_9 build of /usr/ports/japanese/alias-fonts ended at Mon Aug 25 09:33:17 CEST 2014 build time: 00:00:10 So pkg-deinstall has to be fixed I think
pkg-install copies to .orig too
A commit references this bug: Author: marino Date: Mon Aug 25 07:48:13 UTC 2014 New revision: 366038 URL: http://svnweb.freebsd.org/changeset/ports/366038 Log: Stage japanese/alias-fonts and assign maintainership to submitter PR: 192965 Submitted by: WATANABE Kazuhiro Stage fixes: marino Changes: head/japanese/alias-fonts/Makefile head/japanese/alias-fonts/pkg-deinstall head/japanese/alias-fonts/pkg-install head/japanese/alias-fonts/pkg-plist
I knew this port would be troublesome. There were several issues beyond your PR that needed to be addressed. It builds cleanly now and according to "poudriere testport", it's doing the right thing as far as I can tell. I removed the do-install target completely. It was just running post-install which means post-install would get run twice. On the pkg-*nstall scripts, I removed the .orig file at the end of it's processing.