Bug 192979 - [stage] sysutils/bsdadminscripts: add STAGE support, take maintainership
Summary: [stage] sysutils/bsdadminscripts: add STAGE support, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-24 21:38 UTC by Carlos J Puga Medina
Modified: 2014-08-25 14:13 UTC (History)
1 user (show)

See Also:

Attachments
patch-bsdadminscripts.diff (4.35 KB, patch)
2014-08-24 21:38 UTC, Carlos J Puga Medina 		no flags Details | Diff
patch-bsdadminscripts.diff (4.35 KB, patch)
2014-08-24 21:53 UTC, Carlos J Puga Medina 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J Puga Medina 2014-08-24 21:38:41 UTC 
Created attachment 146232 [details]
patch-bsdadminscripts.diff

- Bump PORTREVISION
- Add STAGE support
- Add LICENSE
- Regenerate patch to apply cleanly
- Fix DOCS option
- Fix pkg-plist
- Take maintainership
Comment 1 Carlos J Puga Medina 2014-08-24 21:39:30 UTC 
Build logs via redports:

https://redports.org/buildarchive/20140824212800-28868/
Comment 2 Carlos J Puga Medina 2014-08-24 21:53:15 UTC 
Created attachment 146233 [details]
patch-bsdadminscripts.diff
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-24 23:15:41 UTC 
[patch] is redundant to [stage].  You can't stage without a patch, so that's implied. :)
Comment 4 Carlos J Puga Medina 2014-08-24 23:22:59 UTC 
(In reply to John Marino from comment #3)
> [patch] is redundant to [stage].  You can't stage without a patch, so that's
> implied. :)

Thanks for the tip :)
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-25 08:48:32 UTC 
the MANCOMPRESSED needs to go.
I don't like where this EVALDOC is.  Even if it works (and I'm not sure it does), it shouldn't be defined in post-install target.  It doesn't look right.

I'm not wild about the unnecessary install loops but I'm not going to worry about it today.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-08-25 08:59:03 UTC 
A commit references this bug:

Author: marino
Date: Mon Aug 25 08:58:16 UTC 2014
New revision: 366045
URL: http://svnweb.freebsd.org/changeset/ports/366045

Log:
  Stage sysutils/bsdadminscripts and assign maintainership to submitter

  PR:		192979
  Submitted by:	Carlos JPM

Changes:
  head/sysutils/bsdadminscripts/Makefile
  head/sysutils/bsdadminscripts/files/patch-pkg_libchk
  head/sysutils/bsdadminscripts/pkg-plist
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-25 09:00:53 UTC 
okay, done.

FYI, those git patches give me fits with "svn patch".  I have to manually remove the "/usr/ports/" prefix from each +++ and --- line to get it to apply.  I don't know the "-p" equivalent for svn patch (or if there even is one)
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-08-25 14:13:19 UTC 
A commit references this bug:

Author: marino
Date: Mon Aug 25 14:12:19 UTC 2014
New revision: 366079
URL: http://svnweb.freebsd.org/changeset/ports/366079

Log:
  sysutils/bsdadminscripts: fix scripts in sbin, make them executable

  PR:	192979

Changes:
  head/sysutils/bsdadminscripts/Makefile