Bug 193249 - net/zebra: Adapt to raw_socket changes
Summary: net/zebra: Adapt to raw_socket changes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bryan Drewery
URL: https://wiki.freebsd.org/SOCK_RAW
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-02 10:12 UTC by olivier
Modified: 2019-10-13 21:36 UTC (History)
2 users (show)

See Also:

Attachments
net/zebra patch for sock_raw (3.03 KB, patch)
2014-09-02 10:12 UTC, olivier 		no flags Details | Diff
poudriere log and portlint (167.87 KB, text/plain)
2014-09-04 09:26 UTC, olivier 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description olivier 2014-09-02 10:12:41 UTC 
Created attachment 146673 [details]
net/zebra patch for sock_raw

Following the commit r270929 in -current (detail here: https://wiki.freebsd.org/SOCK_RAW), zebra needs to be patched (attached).
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2014-09-03 20:48:38 UTC 
over to maintainer
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-04 08:17:01 UTC 
Olivier, to help progress these, please attach:

- poudriere (preferred) or redports build logs
- portlint -AC output
Comment 3 olivier 2014-09-04 09:26:56 UTC 
Created attachment 146772 [details]
poudriere log and portlint
Comment 4 John Marino freebsd_committer freebsd_triage 2014-09-20 18:18:57 UTC 
Bryan, technically this PR timed out and I should move it to patch-ready status (i.o.w. maintainer approval no longer required).  I've been doing exactly this for the last hour to many PRs.  However, for you I'm only going to ping the PR but in fairness you should try to take care of this ASAP.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-10-08 16:06:49 UTC 
Okay, this PR timed out twice.  I'm moving it to patch-ready status in fairness to the submitter.
Comment 6 Bryan Drewery freebsd_committer freebsd_triage 2014-10-08 16:09:07 UTC 
Sorry I only saw this today. I will commit soon.
Comment 7 Bryan Drewery freebsd_committer freebsd_triage 2014-10-08 16:09:59 UTC 
(In reply to John Marino from comment #4)
> Bryan, technically this PR timed out and I should move it to patch-ready
> status (i.o.w. maintainer approval no longer required).  I've been doing
> exactly this for the last hour to many PRs.  However, for you I'm only going
> to ping the PR but in fairness you should try to take care of this ASAP.

Yes it was a timeout and anyone could commit it at that point. Since you're maintaining the bug queue please know that I generally implicitly approve "just fixing it" in my ports.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-10-08 17:42:32 UTC 
A commit references this bug:

Author: bdrewery
Date: Wed Oct  8 17:42:13 UTC 2014
New revision: 370473
URL: https://svnweb.freebsd.org/changeset/ports/370473

Log:
  - Fix raw sockets for FreeBSD 11

  PR:		193249
  Submitted by:	olivier@cochard.me

Changes:
  head/net/zebra/Makefile
  head/net/zebra/files/patch-ospfd_ospf_dump.c
  head/net/zebra/files/patch-ospfd_ospf_packet.c
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-10-08 17:43:34 UTC 
A commit references this bug:

Author: bdrewery
Date: Wed Oct  8 17:42:37 UTC 2014
New revision: 370474
URL: https://svnweb.freebsd.org/changeset/ports/370474

Log:
  MFH: r370473

  - Fix raw sockets for FreeBSD 11

  PR:		193249
  Submitted by:	olivier@cochard.me

Changes:
_U  branches/2014Q4/
  branches/2014Q4/net/zebra/Makefile
  branches/2014Q4/net/zebra/files/patch-ospfd_ospf_dump.c
  branches/2014Q4/net/zebra/files/patch-ospfd_ospf_packet.c
Comment 10 commit-hook freebsd_committer freebsd_triage 2019-10-13 12:59:55 UTC 
A commit references this bug:

Author: jbeich
Date: Sun Oct 13 12:59:50 UTC 2019
New revision: 514389
URL: https://svnweb.freebsd.org/changeset/ports/514389

Log:
  net/zebra: drop FreeBSD < 11.0 fix after r483654

  ospfd/ospf_dump.c had a typo, so rebuild is required.

  PR:		193249

Changes:
  head/net/zebra/Makefile
  head/net/zebra/files/patch-ospfd_ospf_dump.c
  head/net/zebra/files/patch-ospfd_ospf_packet.c