Bug 193319 - ports editors/vim-lite libiconv missing
Summary: ports editors/vim-lite libiconv missing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-04 17:05 UTC by Harald Schmalzbauer
Modified: 2014-09-09 17:10 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Schmalzbauer 2014-09-04 17:05:12 UTC
When compiling editors/vim-lite, config.mk results in
LIBS = -lm -lelf  -ltermlib -liconv
                         –> -liconv <–

This, in my case, is due to libiconv has been installed for building-dependency of glib20, required by a different port.
If I make a package of vim-lite, there's no dependency on libiconv registered.
Running vim after installation of that package results in
Shared object "libiconv.so.3" not found, required by "vim"

I can see that Makefile has
USES= cpe iconv pkgconfig shebangfix tar:bzip2
but
'make package-depends-list' lacks libiconv (is empty).

package-depends-list shows libiconv when using "vim" instead of "vim-lite".

Can't find the reason in the Makefile, must be in the nature of USES!?

My first idea was to add an port option which disables -liconv if not choosen to depend on libiconv.
But probably it's meant to depend unconditionally on libiconv - which doesn't work for slave port vim-lite for any reason. Sorry, haven't found the cause yet.

But vim-lite packaging is broken at the moment!
Comment 1 John Marino freebsd_committer freebsd_triage 2014-09-04 18:09:13 UTC
over to maintainer
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2014-09-08 15:32:21 UTC
Please try this patch (http://people.FreeBSD.org/~sunpoet/vim.patch). Thanks!
Comment 3 Harald Schmalzbauer 2014-09-08 16:02:41 UTC
(In reply to Sunpoet Po-Chuan Hsieh from comment #2)
> Please try this patch (http://people.FreeBSD.org/~sunpoet/vim.patch). Thanks!

Thanks a lot, this fixes the packaging problem.
But I'm wondering why USES=iconv in master Makefile has no effect?
 Thanks,

-Harry
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2014-09-09 17:09:44 UTC
(In reply to Harald Schmalzbauer from comment #3)
> (In reply to Sunpoet Po-Chuan Hsieh from comment #2)
> > Please try this patch (http://people.FreeBSD.org/~sunpoet/vim.patch). Thanks!
> 
> Thanks a lot, this fixes the packaging problem.
> But I'm wondering why USES=iconv in master Makefile has no effect?
>  Thanks,
> 
> -Harry

This problem only affects users of FreeBSD 10 or above because we have iconv functionality in libc on such versions. USES=iconv handles iconv-related variables correctly but vim's configure does not aware of this. It simply adds hard-coded "-liconv" if iconv is detected. That's why we need to patch configure manually.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-09-09 17:10:00 UTC
A commit references this bug:

Author: sunpoet
Date: Tue Sep  9 17:09:26 UTC 2014
New revision: 367751
URL: http://svnweb.freebsd.org/changeset/ports/367751

Log:
  - Fix unconditionally dependency on libiconv.so from converters/libiconv
  - Bump PORTREVISION for package change

  PR:		ports/193319
  Reported by:	Harald Schmalzbauer <bugzilla.freebsd@omnilan.de>

Changes:
  head/editors/vim/Makefile
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2014-09-09 17:10:20 UTC
Committed. Thanks!