Bug 193414 - [PATCH] net/samba36: replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo"
Summary: [PATCH] net/samba36: replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Timur I. Bakeyev
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2014-09-07 08:13 UTC by Yasuhiro Kimura
Modified: 2014-11-19 01:25 UTC (History)
1 user (show)

See Also:

Attachments
Replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo". (817 bytes, patch)
2014-09-07 08:13 UTC, Yasuhiro Kimura 		koobs: maintainer-approval? (timur)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2014-09-07 08:13:53 UTC 
Created attachment 146984 [details]
Replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo".
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-07 13:15:23 UTC 
Comment on attachment 146984 [details]
Replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo".

If possible please also include the following to promote quick 
resolution:

 * Attach successful poudriere testport, or redports.org build logs
 * portlint -AC output (after addressing any outstanding issues)
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-09-07 14:31:40 UTC 
(In reply to Kubilay Kocak from comment #1)
> Comment on attachment 146984 [details]
> Replace "LIB_DEPENDS=libexecinfo.so" with "USES=execinfo".
> 
> If possible please also include the following to promote quick 
> resolution:
> 
>  * Attach successful poudriere testport, or redports.org build logs

https://redports.org/buildarchive/20140907060601-18389/

>  * portlint -AC output (after addressing any outstanding issues)

yasu@eastasia[53471]% cd /usr/ports/net/samba36
yasu@eastasia[53472]% portlint -AC
WARN: Makefile: [0]: possible direct use of command "rmdir" found. use ${RMDIR} instead.
WARN: Makefile: possible use of absolute pathname "/var".
WARN: Makefile: possible use of absolute pathname "/usr".
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
0 fatal errors and 7 warnings found.
yasu@eastasia[53473]%
Comment 3 Timur I. Bakeyev freebsd_committer freebsd_triage 2014-09-08 22:06:19 UTC 
Thanks a lot for the patch. Please, go ahead with the commit.
Comment 4 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-09-27 08:28:27 UTC 
Reopen PR because patch is approved but not committed yet.
Comment 5 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-11-19 01:25:07 UTC 
Patch is committed by r372749. Thanks Timur!