Bug 193428 - [MAINTAINER] lang/x10: Add BROKEN for FreeBSD <= 9.2
Summary: [MAINTAINER] lang/x10: Add BROKEN for FreeBSD <= 9.2
Status: Closed Unable to Reproduce
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2014-09-07 13:14 UTC by Jason W. Bacon
Modified: 2014-10-08 14:54 UTC (History)
1 user (show)

See Also:


Attachments
Unified diff (481 bytes, patch)
2014-09-07 13:14 UTC, Jason W. Bacon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason W. Bacon freebsd_committer freebsd_triage 2014-09-07 13:14:12 UTC
Created attachment 147007 [details]
Unified diff

Quick fix to silence package build errors on 9.1 by requiring 9.2 or later.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-09-11 15:01:44 UTC
Please resubmit patch with change:

.if ${OSVERSION} <= 90100 

to

.if ${OPSYS} == FreeBSD && ${OSVERSION} <= 90100
Comment 2 John Marino freebsd_committer freebsd_triage 2014-10-08 14:12:07 UTC
Are you sure it's not building on 9.1 or 8.4?  Portsmon says it is building fine:
http://portsmon.freebsd.org/portoverview.py?category=lang&portname=x10
Comment 3 Jason W. Bacon freebsd_committer freebsd_triage 2014-10-08 14:20:41 UTC
I received a report that package building was failing on 9.1.  I haven't had time to verify it, hence the patch.

In all honesty, I think this port could be deprecated.  It's outdated and I don't think anyone is using it, so I'd rather not sink time into it.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-10-08 14:54:12 UTC
Actually, that's not a very good reason.  Patching a port without A) understanding the issue or B) even verifying that it's repeatable just to stop getting pkg-fallout messages isn't a good idea.

Also, people have to spend time processing the PR and verifying commits.  Even a simple 3-line patch costs a lot of time.  Some effort should go into the submittal before a committer spends time on it, no?

I'm going to close the PR.  If you want to release / deprecate the port, that's fine, just open a new PR for that, thanks.