Bug 193434 - [regression] Mk/Uses/scons.mk doesn't respect CFLAGS/LDFLAGS unlike Mk/bsd.scons.mk
Summary: [regression] Mk/Uses/scons.mk doesn't respect CFLAGS/LDFLAGS unlike Mk/bsd.sc...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-python (Nobody)
URL:
Keywords:
Depends on:
Blocks: 188382 195964
  Show dependency treegraph
 
Reported: 2014-09-07 17:03 UTC by Jan Beich
Modified: 2015-01-22 18:55 UTC (History)
1 user (show)

See Also:


Attachments
restore default flags (424 bytes, patch)
2014-09-07 17:03 UTC, Jan Beich
no flags Details | Diff
|poudriere bulk -t| logs (283.00 KB, application/x-xz)
2015-01-22 15:38 UTC, Jan Beich
no flags Details
csound workaround (344 bytes, patch)
2015-01-22 16:11 UTC, Jan Beich
no flags Details | Diff
|poudriere bulk -t| logs (696.82 KB, application/x-xz)
2015-01-22 18:02 UTC, Jan Beich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2014-09-07 17:03:04 UTC
Created attachment 147017 [details]
restore default flags

This breaks passing -Wl,-rpath from Mk/bsd.gcc.mk where some ports may depend on newer version of GCC libraries (libstdc++.so, libgcc_s.so, etc).
Comment 1 Jan Beich freebsd_committer 2015-01-22 15:38:44 UTC
Created attachment 152016 [details]
|poudriere bulk -t| logs

Bulk build of scons consumers false positives:

  games/gtkradiant (already marked BROKEN)
  games/paintown (stage-qa fails on strip(1) check)

and one real failure:

  audio/csound
Comment 2 Jan Beich freebsd_committer 2015-01-22 16:11:03 UTC
Created attachment 152018 [details]
csound workaround

LINKFLAGS as inherited from environment aren't properly split. And LDFLAGS are appended regardless. So, this patch fixes the following error but otherwise does nothing without attachment 147017 [details].

cc -o libcsound64.so.5 " -pthread -Wl,-export-dynamic" -pthread -Wl,-export-dynamic -shared -Wl,-soname=libcsound64.so.5 Engine/auxfd.os ... -lm
cc:  -pthread -Wl,-export-dynamic: No such file or directory
Comment 3 Jan Beich freebsd_committer 2015-01-22 18:02:32 UTC
Created attachment 152022 [details]
|poudriere bulk -t| logs

Fresh batch of logs with audio/csound green.
Comment 4 commit-hook freebsd_committer 2015-01-22 18:53:02 UTC
A commit references this bug:

Author: jbeich
Date: Thu Jan 22 18:52:27 UTC 2015
New revision: 377692
URL: https://svnweb.freebsd.org/changeset/ports/377692

Log:
  Pass CFLAGS and LDFLAGS by default to scons build, again

  This fixes r355494 regression.

  PR:		193434
  Differential Revision:	https://reviews.freebsd.org/D1602
  Reviewed by:	bapt
  Approved by:	bapt (mentor)
  Approved by:	portmgr (bapt)

Changes:
  head/Mk/Uses/scons.mk
  head/audio/csound/Makefile