Created attachment 147048 [details] shar Baka MPlayer is a free and open source, cross-platform, libmpv based multimedia player. Its simple design reflects the idea for an uncluttered, simple, and enjoyable environment for watching anime. WWW: http://bakamplayer.u8sand.net/ I'm not sure about category. Does it need "audio" like multimedia/mpv? The interface seems video-oriented but has playlist and displays album art/black box for audio files.
Created attachment 147049 [details] shar Oops, old version.
Created attachment 147050 [details] |poudriere testport -P| log (9.3R i386) Ignore the following invalid error. portlint and bsd.port.mk disagree about empty StartupNotify. $ portlint -AC FATAL: Makefile: Use true/false (without quotes) instead of ${TRUE}/${FALSE} in DESKTOP_ENTRIES. 1 fatal error and 0 warnings found.
Created attachment 147051 [details] |poudriere testport -P| log (10.0R amd64)
It does not need an audio category, but additional categories help classifying the port and its capabilities. Over to Patch Ready.
Created attachment 147417 [details] shar, v1.1 Added runtime dependency on qt5-svg or button wouldn't be visible. Noticed after CMake and PKGBUILD changes in git master.
Created attachment 147771 [details] shar, v2 - update to 1.9.9-alpha - switch from qmake to cmake/ninja - temporarily disable "always on top" due to missing qt5-x11extras - use vendor desktop file - kill @dirrmtry (per CHANGES from 20140922)
Created attachment 147772 [details] |poudriere testport -P| log (9.3R i386)
Created attachment 147782 [details] shar, v2 + x11extras version to land after bug 194008
Created attachment 147783 [details] |poudriere testport -P| log (9.3R i386, x11extras)
Created attachment 147785 [details] |poudriere testport -P| log (9.3R i386, x11extras) Oops, incomplete log.
Comment on attachment 147771 [details] shar, v2 No need for workaround after bug 194008 landed.
Created attachment 148467 [details] amendments I made some changes to the port (see the patch vs your last version). I propose to not force dependence on Noto fonts (~140Mb), since the player works fine without it. I plainly removed it from the port, alternative solutions are 1) mention in pkg-message that x11-fonts/noto can be installed to obtain original look&feel 2) install NotoSans-Regular.ttf shipped with the baka-mplayer tarball
Created attachment 148470 [details] shar, v3 Integrated attachment 148467 [details] except for > +post-patch: > + ${REINPLACE_CMD} '/^Comment/s,=.*,=${COMMENT},' \ > + ${WRKSRC}/etc/sbin/pkgbuild/${PORTNAME}.desktop > + Patch conflict is easier to notice unlike irrelevance of sed(1) lines after update. https://github.com/u8sand/Baka-MPlayer/commit/d8fa8cb > 1) mention in pkg-message that x11-fonts/noto can be installed to obtain original look&feel A port option would convey the intention better. > 2) install NotoSans-Regular.ttf shipped with the baka-mplayer tarball This may affect LICENSE of the port. https://www.gnu.org/licenses/license-list.html#apache2
Created attachment 148471 [details] |poudriere testport -P| log (9.3R i386) for NOTO=off (default)
Created attachment 148472 [details] |poudriere testport -P| log (9.3R i386) for NOTO=on
(In reply to Jan Beich from comment #13) > Created attachment 148470 [details] > shar, v3 at this stage you don't need to regenerate shar, I'm almost ready to commit the port and just wanted to clarify last details. > > Integrated attachment 148467 [details] except for > > > +post-patch: > > + ${REINPLACE_CMD} '/^Comment/s,=.*,=${COMMENT},' \ > > + ${WRKSRC}/etc/sbin/pkgbuild/${PORTNAME}.desktop > > + > > Patch conflict is easier to notice unlike irrelevance of sed(1) lines after > update. You're right in general, but in this particular case it's overkill. The patch is too trivial for creating a separate file, it's not specific to FreeBSD for keeping it in the portstree. Submit your patch upstream, and then simply remove sed on the next port upgrade. (Please, omit "Baka MPlayer is a free and open source, cross-platform," from your patch. It's appropriate for port description, but not for comment. See recommendations: http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys ) > > https://github.com/u8sand/Baka-MPlayer/commit/d8fa8cb > > > 1) mention in pkg-message that x11-fonts/noto can be installed to obtain > original look&feel > > A port option would convey the intention better. Ok
A commit references this bug: Author: makc Date: Sun Oct 19 21:42:40 UTC 2014 New revision: 371210 URL: https://svnweb.freebsd.org/changeset/ports/371210 Log: Add new port multimedia/baka-mplayer: Qt 5 multimedia player based on Mpv. WWW: http://bakamplayer.u8sand.net/ PR: 193455 Submitted by: Jan Beich Changes: head/multimedia/Makefile head/multimedia/baka-mplayer/ head/multimedia/baka-mplayer/Makefile head/multimedia/baka-mplayer/distinfo head/multimedia/baka-mplayer/files/ head/multimedia/baka-mplayer/files/patch-src__ui__mainwindow.ui head/multimedia/baka-mplayer/pkg-descr head/multimedia/baka-mplayer/pkg-plist
Committed, thanks!