Bug 193466 - [NEW PORT] sysutils/colwide: A utility which outputs a number of characters to the screen
Summary: [NEW PORT] sysutils/colwide: A utility which outputs a number of characters t...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2014-09-08 18:56 UTC by Neel Chauhan
Modified: 2014-09-24 13:56 UTC (History)
2 users (show)

See Also:


Attachments
shar file for the sysutils/colwide port (1.56 KB, text/plain)
2014-09-08 18:56 UTC, Neel Chauhan
no flags Details
Updated shar file for the sysutils/colwide port (1.57 KB, text/plain)
2014-09-19 17:10 UTC, Neel Chauhan
no flags Details
Poudriere log file for sysutils/colwide (7.17 KB, text/x-log)
2014-09-19 17:10 UTC, Neel Chauhan
no flags Details
Fixed shar file for the sysutils/colwide port (1.57 KB, text/plain)
2014-09-23 12:55 UTC, Neel Chauhan
no flags Details
Updated and CORRECT shar file for the sysutils/colwide port (1.73 KB, text/plain)
2014-09-23 16:02 UTC, Neel Chauhan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer freebsd_triage 2014-09-08 18:56:46 UTC
Created attachment 147078 [details]
shar file for the sysutils/colwide port

colwide is a Perl script which displays either 80 or specified number of hash (#) characters on the screen. Can be useful to determine terminal width.
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2014-09-17 17:56:06 UTC
Patch looks good, moving to Patch Ready
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-19 10:45:47 UTC
Does not fetch: you don't need :dist in MASTER_SITES. You should also use

EXTRACT_ONLY=   # empty

to make it explicit. Finally, I don't like that distfile in not versioned: if it's updated, users will have checksum errors. Distfile mirroring would also be a problem. Better wrap it into e.g. colwide-0.01.tar.gz
Comment 3 Neel Chauhan freebsd_committer freebsd_triage 2014-09-19 17:10:13 UTC
Created attachment 147469 [details]
Updated shar file for the sysutils/colwide port
Comment 4 Neel Chauhan freebsd_committer freebsd_triage 2014-09-19 17:10:49 UTC
Created attachment 147470 [details]
Poudriere log file for sysutils/colwide
Comment 5 Neel Chauhan freebsd_committer freebsd_triage 2014-09-19 17:12:34 UTC
I have updated the shar file for the proposed sysutils/colwide port. The new file is attached, along with the Poudriere build log used to test compilation of the sysutils/colwide port.
-Neel
Comment 6 Neel Chauhan freebsd_committer freebsd_triage 2014-09-19 17:13:17 UTC
(In reply to neel from comment #5)
> I have updated the shar file for the proposed sysutils/colwide port. The new
> file is attached, along with the Poudriere build log used to test
> compilation of the sysutils/colwide port.
> -Neel

I forgot to mention I did not attach the files to comment #5, but to #3 and #4.
-Neel
Comment 7 Neel Chauhan freebsd_committer freebsd_triage 2014-09-22 17:16:55 UTC
Is there any status on committing the sysutils/colwide port?
Comment 8 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-22 18:46:26 UTC
===>  License BSD2CLAUSE accepted by the user
===>   colwide-0.01 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by colwide-0.01 for building
===>  Extracting for colwide-0.01
=> SHA256 Checksum OK for colwide-0.01.
===>  Patching for colwide-0.01
===>  Configuring for colwide-0.01
===>  Staging for colwide-0.01
===>   colwide-0.01 depends on file: /usr/local/bin/perl5.18.2 - found
===>   Generating temporary packing list
install   -m 555 /usr/distfiles/colwide-0.01 /tmp/colwide/work/stage/tmp/colwide/prefix/bin/colwide
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
Error: '/usr/bin/perl' is an invalid shebang you need USES=shebangfix for 'bin/colwide'
*** Error code 1

You probably need to copy distfile into ${WRKSRC} on do-extract and add USES=shebangfix to fix perl path in there. Otherwise looks good.
Comment 9 Neel Chauhan freebsd_committer freebsd_triage 2014-09-23 12:55:33 UTC
Created attachment 147598 [details]
Fixed shar file for the sysutils/colwide port

Hi amdmi3@,
Related to what you said on Comment #8, I have addressed this shebang error and have uploaded an updated shar file for the sysutils/colwide port.
-Neel
Comment 10 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-23 15:22:11 UTC
There doesn't seem to be any difference between this and previous version of the shar.
Comment 11 Neel Chauhan freebsd_committer freebsd_triage 2014-09-23 16:02:50 UTC
Created attachment 147603 [details]
Updated and CORRECT shar file for the sysutils/colwide port

Hi @amdmi3,
Related to what you said on Comment #10, it turned out I did upload the old shar file again. My mistake. I did I upload the correct shar file now.
-Neel
Comment 12 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-23 17:43:58 UTC
Ok, looks good. I forgot one more thing - sysutils doesn't really seem as a suitable category for this, I'd think of misc instead. What do you think?
Comment 13 Neel Chauhan freebsd_committer freebsd_triage 2014-09-23 18:27:18 UTC
(In reply to Dmitry Marakasov from comment #12)
> Ok, looks good. I forgot one more thing - sysutils doesn't really seem as a
> suitable category for this, I'd think of misc instead. What do you think?

You have my approval for doing this! If I was doing this again, I would have chose misc instead of sysutils.
Comment 14 commit-hook freebsd_committer freebsd_triage 2014-09-24 13:56:43 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Sep 24 13:56:27 UTC 2014
New revision: 369180
URL: http://svnweb.freebsd.org/changeset/ports/369180

Log:
  colwide is a Perl script which displays either 80 or specified number of hash
  (#) characters on the screen. Can be useful to determine terminal width.

  WWW: http://www.neelc.org/software/colwide/

  PR:		193466
  Submitted by:	neel@neelc.org

Changes:
  head/misc/Makefile
  head/misc/colwide/
  head/misc/colwide/Makefile
  head/misc/colwide/distinfo
  head/misc/colwide/pkg-descr