Bug 193515 - [PATCH] games/freeciv: removes ggz.modules file on deinstall
Summary: [PATCH] games/freeciv: removes ggz.modules file on deinstall
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-10 12:16 UTC by Dmitry Marakasov
Modified: 2014-12-03 13:40 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2014-09-10 12:16:57 UTC
freeciv lists ggz.modules file in its plist, while it actually belongs to ggz-client-libs port.

Poudriere finds this:

---
=======================<phase: deinstall      >============================
===>  Deinstalling for freeciv
===>   Deinstalling freeciv-2.4.3
Updating database digests format... done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	freeciv-2.4.3

The operation will free 46 MB.
[10-amd64-default] [1/1] Deleting freeciv-2.4.3... done
===========================================================================
====>> Checking for extra files and directories
====>> Files or directories removed:
etc/ggz.modules
build of /usr/ports/games/freeciv ended at Wed Sep 10 16:11:42 MSK 2014
====>> Error: Build failed in phase: leftovers
---

Just removing it from plist doesn't help (however it seems to be better than listing it), as the file is modified. Probably it should be handled like fonts cache and other facilities which modify files on install/deinstall instead.

Port maintainer (johans@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
Comment 1 commit-hook freebsd_committer 2014-12-03 13:40:07 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Dec  3 13:39:29 UTC 2014
New revision: 373826
URL: https://svnweb.freebsd.org/changeset/ports/373826

Log:
  - Fix etc/ggz.modules handling
  - Remove @dirrm* from plist

  PR:		193515 [1]
  Submitted by:	amdmi3
  Approved by:	portmgr blanket
  Approved by:	maintainer timeout ([1])

Changes:
  head/games/freeciv/Makefile
  head/games/freeciv/pkg-plist