Bug 193542 - [MAINTAINER] x11-fonts/alef: Bump PORTREVISION
Summary: [MAINTAINER] x11-fonts/alef: Bump PORTREVISION
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-10 20:55 UTC by Carlos J Puga Medina
Modified: 2014-09-12 21:16 UTC (History)
1 user (show)

See Also:


Attachments
alef-1.0_1.diff (1.43 KB, patch)
2014-09-10 20:55 UTC, Carlos J Puga Medina
no flags Details | Diff
alef-1.0_1.diff (2.57 KB, patch)
2014-09-12 09:37 UTC, Carlos J Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J Puga Medina 2014-09-10 20:55:38 UTC
Created attachment 147197 [details]
alef-1.0_1.diff

- Clean-up Makefile
- Bump PORTREVISION
Comment 1 Carlos J Puga Medina 2014-09-10 22:59:27 UTC
Build logs via redports:

https://redports.org/buildarchive/20140910225252-52728/
Comment 2 Jason E. Hale freebsd_committer 2014-09-12 03:10:38 UTC
- Comment should not start with indefinite article "A"
- Installation commands should not be muted (mkdirs OK)
- Installation of DOCS should not be conditional.  Staging will take care of it automatically
- To install the DOCS without the for loop, the easiest way is:
  ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKDIR}/|} ${STAGEDIR}${DOCSDIR}
- This port has a BUILD_DEPENDS on fc-cache(1), which it doesn't even use
- It should be running mkfontdir(1) and mkfontscale(1) in the directory where the fonts are.  Of course, the generated files need added to pkg-plist.
- It would be better if NO_WRKSUBDIR were set, then you wouldn't have to redefine WRKSRC and it would eliminate the first two lines of the post-extract target.
- Since LICENSE_FILE is being added, it should be removed from PORTDOCS so that it isn't installed twice
Comment 3 Carlos J Puga Medina 2014-09-12 09:37:07 UTC
Created attachment 147241 [details]
alef-1.0_1.diff
Comment 4 Carlos J Puga Medina 2014-09-12 09:37:55 UTC
(In reply to Jason E. Hale from comment #2)
> - Comment should not start with indefinite article "A"
> - Installation commands should not be muted (mkdirs OK)
> - Installation of DOCS should not be conditional.  Staging will take care of
> it automatically
> - To install the DOCS without the for loop, the easiest way is:
>   ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKDIR}/|} ${STAGEDIR}${DOCSDIR}
> - This port has a BUILD_DEPENDS on fc-cache(1), which it doesn't even use
> - It should be running mkfontdir(1) and mkfontscale(1) in the directory
> where the fonts are.  Of course, the generated files need added to pkg-plist.
> - It would be better if NO_WRKSUBDIR were set, then you wouldn't have to
> redefine WRKSRC and it would eliminate the first two lines of the
> post-extract target.
> - Since LICENSE_FILE is being added, it should be removed from PORTDOCS so
> that it isn't installed twice

Done! Thank you for the triage.
Comment 5 Carlos J Puga Medina 2014-09-12 09:40:07 UTC
% portlint -ac
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 1 warning found.

Build logs via redports (after last port revision):

https://redports.org/buildarchive/20140912091400-49436/
Comment 6 commit-hook freebsd_committer 2014-09-12 21:15:21 UTC
A commit references this bug:

Author: jhale
Date: Fri Sep 12 21:15:15 UTC 2014
New revision: 368067
URL: http://svnweb.freebsd.org/changeset/ports/368067

Log:
  - Drop indefinite article from COMMENT
  - Add LICENSE_FILE and remove it from PORTDOCS
  - Use NO_WRKSUBDIR to avoid redefining WRKSRC
  - Create and install font indexes
  - Simplify PORTDOCS installation
  - Bump PORTREVISION

  PR:		193542
  Submitted by:	Carlos Jacobo Puga Medina <cpm@fbsd.es> (maintainer)

Changes:
  head/x11-fonts/alef/Makefile
  head/x11-fonts/alef/pkg-plist
Comment 7 Jason E. Hale freebsd_committer 2014-09-12 21:16:04 UTC
Committed with minor changes.  Thanks!