Bug 193807 - multimedia/vlc fails to use OSS backend after recent upgrade
Summary: multimedia/vlc fails to use OSS backend after recent upgrade
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-21 11:31 UTC by Hans Petter Selasky
Modified: 2014-12-13 18:55 UTC (History)
1 user (show)

See Also:

Attachments
Updated OSS patch for VLC port. (1.23 KB, patch)
2014-09-21 11:31 UTC, Hans Petter Selasky 		no flags Details | Diff
QT4 GUI OSS options patch (917 bytes, patch)
2014-12-09 09:55 UTC, Hans Petter Selasky 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Petter Selasky freebsd_committer freebsd_triage 2014-09-21 11:31:01 UTC 
Created attachment 147522 [details]
Updated OSS patch for VLC port.

Hi,

VLC fails with the OSS audio output backend because the return value from SNDCTL_DSP_GETODELAY is used improperly. The manual says:

http://manuals.opensound.com/developer/SNDCTL_DSP_GETODELAY.html

That the values is in number of bytes, but VLC thinks it is the number of buffer fragments buffered.

I've updated an patch for VLC. Should be upstreamed!

--HPS
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2014-12-06 19:45:13 UTC 
Is this still an issue?
Comment 2 Hans Petter Selasky freebsd_committer freebsd_triage 2014-12-06 20:24:11 UTC 
I'll re-check and let you know by tuesday.

--HPS
Comment 3 Hans Petter Selasky freebsd_committer freebsd_triage 2014-12-09 09:54:19 UTC 
Hi,

This issue is not solved. To reproduce:

1) select "Tools"
2) select "Audio Settings"
3) enable "Enable Time-Stretching audio"
4) after some time of playback, audio gets choppy!

The patch should be upstreamed!

There is one more BUG, and that is that a BROWSE button in the QT4 GUI for OSS preferences is missing, and appears as a separate window! See second attachment to this PR! Should also be upstreamed!

Thank you!

--HPS
Comment 4 Hans Petter Selasky freebsd_committer freebsd_triage 2014-12-09 09:55:00 UTC 
Created attachment 150391 [details]
QT4 GUI OSS options patch
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-12-13 18:50:16 UTC 
A commit references this bug:

Author: riggs
Date: Sat Dec 13 18:49:27 UTC 2014
New revision: 374673
URL: https://svnweb.freebsd.org/changeset/ports/374673

Log:
  - Fix buffering in OSS backend
  - Fix QT4 GUI layout issue

  While one it:
  - Use INSTALLS_ICONS

  PR:		193807
  Submitted by:	hselasky@FreeBSD.org

Changes:
  head/multimedia/vlc/Makefile
  head/multimedia/vlc/files/patch-c1622c2c6e0e15a38fef723086ca8bf75a75b46b-2.1.5
  head/multimedia/vlc/files/patch-modules-audio_output-oss.c
  head/multimedia/vlc/files/patch-modules-gui-qt4-components-simple_preferences.cpp
Comment 6 Thomas Zander freebsd_committer freebsd_triage 2014-12-13 18:55:37 UTC 
Committed, thanks!