Bug 193822 - multimedia/mpv: add LUAJIT option
Summary: multimedia/mpv: add LUAJIT option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Grzegorz Blach
URL:
Keywords: patch
Depends on: 193821
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-21 20:56 UTC by Jan Beich
Modified: 2014-10-03 14:41 UTC (History)
0 users

See Also:
gblach: maintainer-feedback+

Attachments
v1 (1.71 KB, patch)
2014-09-21 20:56 UTC, Jan Beich 		no flags Details | Diff
|poudriere testport| log (9.3R i386) (83.19 KB, text/plain)
2014-09-21 20:58 UTC, Jan Beich 		no flags Details
|poudriere testport| log (10.0R amd64, LUAJIT=on) (83.09 KB, text/plain)
2014-09-21 21:05 UTC, Jan Beich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2014-09-21 20:56:13 UTC 
Created attachment 147539 [details]
v1

Leaving default as is. If you feel adventurous follow devel/love:

  # lang/luajit is BROKEN elsewhere
  OPTIONS_DEFAULT_i386=   LUAJIT
  OPTIONS_DEFAULT_amd64=  LUAJIT
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-21 20:56:13 UTC 
Auto-assigned to maintainer gblach@FreeBSD.org
Comment 2 Jan Beich freebsd_committer freebsd_triage 2014-09-21 20:58:13 UTC 
Created attachment 147540 [details]
|poudriere testport| log (9.3R i386)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2014-09-21 21:05:27 UTC 
Created attachment 147541 [details]
|poudriere testport| log (10.0R amd64, LUAJIT=on)
Comment 4 Jan Beich freebsd_committer freebsd_triage 2014-09-21 21:06:20 UTC 
Please keep default in sync with multimedia/libquvi to avoid...

  $ make configure
  ...
  Checking for Lua                                                          : no
  You manually enabled the feature 'lua', but the autodetection check failed.
  *** Error code 1

or

  [New Thread 812c06400 (LWP 101313)]
  Playing: http://www.youtube.com/watch?v=ABCDEF

  Program received signal SIGSEGV, Segmentation fault.
  [Switching to Thread 812c06400 (LWP 101313)]
  0x0000000808344ce7 in luaH_getint () from /usr/local/lib/liblua-5.2.so
  (gdb) bt
  #0  0x0000000808344ce7 in luaH_getint () from /usr/local/lib/liblua-5.2.so
  #1  0x0000000808333cb3 in lua_setglobal () from /usr/local/lib/liblua-5.2.so
  #2  0x0000000803142490 in run_ident_func () from /usr/local/lib/libquvi.so.7
  #3  0x0000000803142a3a in find_host_script_node () from /usr/local/lib/libquvi.so.7
  #4  0x00000008031428f1 in find_host_script () from /usr/local/lib/libquvi.so.7
  #5  0x000000080314050c in quvi_supported () from /usr/local/lib/libquvi.so.7
  #6  0x0000000000481cb7 in mp_resolve_quvi ()
  #7  0x000000000045ef01 in mp_play_files ()
  #8  0x000000000046176a in mpv_main ()
  #9  0x000000000040c90f in _start (ap=<optimized out>, cleanup=<optimized out>) at /usr/src/lib/csu/amd64/crt1.c:78
Comment 5 Grzegorz Blach freebsd_committer freebsd_triage 2014-09-24 22:24:48 UTC 
I reported bug with LUAJIT and QUVI to MPV developers. This issue should be solved firstly.
Comment 6 Grzegorz Blach freebsd_committer freebsd_triage 2014-09-24 22:34:37 UTC 
(In reply to Grzegorz Blach from comment #5)
> I reported bug with LUAJIT and QUVI to MPV developers. This issue should be
> solved firstly.

My mistake, I wrongly understood comment about luajit and libquvi.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-09-24 23:03:26 UTC 
A commit references this bug:

Author: gblach
Date: Wed Sep 24 23:02:47 UTC 2014
New revision: 369213
URL: http://svnweb.freebsd.org/changeset/ports/369213

Log:
  - Update to 0.5.4
  - Add option to use LuaJIT instead of Lua [1]

  PR:		193822 [1]
  Submitted by:	Jan Beich (jbeich <at> vfemail <dot> net) [1]

Changes:
  head/multimedia/mpv/Makefile
  head/multimedia/mpv/distinfo
  head/multimedia/mpv/pkg-plist