Bug 193849 - www/xpi-conkeror builds from very old source code
Summary: www/xpi-conkeror builds from very old source code
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: Normal Affects Many People
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-22 20:29 UTC by r004
Modified: 2014-10-03 08:24 UTC (History)
2 users (show)

See Also:
roo4.id: maintainer-feedback-


Attachments
UNCOMPLETE diff patch for Makefile (3.13 KB, patch)
2014-09-22 20:29 UTC, r004
no flags Details | Diff
update to 20140812 snapshot (3.33 KB, patch)
2014-09-23 15:19 UTC, Jan Beich
no flags Details | Diff
update to 20140812 snapshot (3.27 KB, patch)
2014-09-23 15:37 UTC, Jan Beich
no flags Details | Diff
|poudriere testport -P| log (9.3R i386) (24.73 KB, text/plain)
2014-09-23 18:31 UTC, Jan Beich
no flags Details
|poudriere testport -P| log (10.0R amd64, FIREFOX=on) (26.22 KB, text/plain)
2014-09-23 19:45 UTC, Jan Beich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description r004 2014-09-22 20:29:58 UTC
Created attachment 147572 [details]
UNCOMPLETE diff patch for Makefile

According to conkeror web site there is a very more recent source code for conkeror but the port maintainers just bump up the version and it actually build from tyhe past source codes.
The main maintainer **ashish** did the favour of making some adjustment. but according to him it is not completely safe.
PLZ someone take it from here and finish the job
thanks
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-22 20:29:58 UTC
Auto-assigned to maintainer ashish@FreeBSD.org
Comment 2 r004 2014-09-23 13:45:01 UTC
if we use http://repo.or.cz/w/conkeror.git?a=snapshot;h=master;sf=tgz' -O conkeror-master.tar.gz in the Makefile we would have the latest snapshot at any time.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2014-09-23 15:19:36 UTC
Created attachment 147601 [details]
update to 20140812 snapshot

git master is a moving target, better use a commit hash or tag so distfile 
checksum wouldn't change over time. Here's a trick.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2014-09-23 15:37:15 UTC
Created attachment 147602 [details]
update to 20140812 snapshot

Doh, the following URL is easier to work with.

http://repo.or.cz/w/conkeror.git/snapshot/d87d0b8.tar.gz
Comment 5 r004 2014-09-23 16:08:59 UTC
Dear Jan;
Is you diff the final and production ready version?
Comment 6 r004 2014-09-23 16:11:34 UTC
also your are right about the source link. thank you
Comment 7 Jan Beich freebsd_committer freebsd_triage 2014-09-23 18:31:13 UTC
Created attachment 147610 [details]
|poudriere testport -P| log (9.3R i386)

It seems the Porter's Handbook agrees with portlint(1) but I cannot find actual rationale. However, looking at DISTVERSION implementation it should work fine with both set. And attached smoke test log confirms my conjecture.

$ portlint -C
FATAL: Makefile: either PORTVERSION or DISTVERSION must be specified, not both.
1 fatal error and 0 warnings found.

Porter's Handbook says:
> Only one of PORTVERSION and DISTVERSION can be set at a time. If DISTVERSION does not derive a correct PORTVERSION, do not use DISTVERSION, set PORTVERSION to the right value and set DISTNAME with PORTNAME with either some computation of PORTVERSION or the verbatim upstream version.

# Mk/bsd.port.mk has
.if defined(PORTVERSION)
.if ${PORTVERSION:M*[-_,]*}x != x
IGNORE=			PORTVERSION ${PORTVERSION} may not contain '-' '_' or ','
.endif
DISTVERSION?=	${PORTVERSION:S/:/::/g}
.elif defined(DISTVERSION)
PORTVERSION=	${DISTVERSION:tl:C/([a-z])[a-z]+/\1/g:C/([0-9])([a-z])/\1.\2/g:C/:(.)/\1/g:C/[^a-z0-9+]+/./g}
.endif
Comment 8 Jan Beich freebsd_committer freebsd_triage 2014-09-23 18:42:38 UTC
The build log also hints about CHANGES from 20140922. It's up to the maintainer to decide when to pull the plug on partial updates.

  ===>  Building package for conkeror-20140812
  pkg-static: Warning: @dirrm is deprecated please use @dir

while

  ====>> Files or directories left over:
  @dirrm /prefix

is a false positive from PREFIX!=LOCALBASE, likely either bsd.port.mk or pkg(8) bug.
Comment 9 Jan Beich freebsd_committer freebsd_triage 2014-09-23 19:45:41 UTC
Created attachment 147614 [details]
|poudriere testport -P| log (10.0R amd64, FIREFOX=on)
Comment 10 r004 2014-09-23 19:57:42 UTC
What is the difference between using xulrunner from firefox port (which port is that exactly; does it mean installing the whole firefox and thus more dep.) and using libxul?
Comment 11 commit-hook freebsd_committer freebsd_triage 2014-10-03 08:23:20 UTC
A commit references this bug:

Author: ashish
Date: Fri Oct  3 08:22:41 UTC 2014
New revision: 369874
URL: https://svnweb.freebsd.org/changeset/ports/369874

Log:
  - Update to latest HEAD

  PR:		193849

Changes:
  head/www/xpi-conkeror/Makefile
  head/www/xpi-conkeror/distinfo
  head/www/xpi-conkeror/pkg-plist
Comment 12 Ashish SHUKLA freebsd_committer freebsd_triage 2014-10-03 08:24:41 UTC
Hi roo4.id,

I've committed the update. I'm not able to reproduce the warnings which I get in redports, nor I've any fix for that. So, I've committed the port update which I planned.

HTH