Bug 193908 - security/clamtk: Update to 5.25, move to github distsite
Summary: security/clamtk: Update to 5.25, move to github distsite
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL: https://github.com/dave-theunsub/clamtk/
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-24 20:53 UTC by Nikos
Modified: 2018-06-06 05:31 UTC (History)
4 users (show)

See Also:
pi: maintainer-feedback-


Attachments
patch (5.34 KB, patch)
2015-10-28 20:45 UTC, Kurt Jaeger
no flags Details | Diff
svn-diff-clamtk (5.20 KB, patch)
2018-06-04 12:58 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-clantk_v2 (5.20 KB, patch)
2018-06-04 13:10 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-clamtk_v3 (5.19 KB, patch)
2018-06-04 13:14 UTC, Walter Schwarzenfeld
no flags Details | Diff
patch-v4 (5.29 KB, patch)
2018-06-05 08:45 UTC, Kurt Jaeger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos 2014-09-24 20:53:08 UTC
Please upgrade  the clamtk 5.07 new homepage
https://code.google.com/p/clamtk/
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2014-09-26 20:25:23 UTC
Over to maintainer.
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-28 20:45:14 UTC
Created attachment 162540 [details]
patch

builds, but does not start, error:

Icon 'gtk-new' not present in theme at /usr/local/lib/perl5/site_perl/ClamTk/GUI.pm line 283.

Any ideas ?
Comment 3 Walter Schwarzenfeld freebsd_triage 2018-01-09 01:32:00 UTC
locate gtk-new
/usr/local/share/icons/Tango/16x16/actions/gtk-new.png

 pkg which /usr/local/share/icons/Tango/16x16/actions/gtk-new.png
/usr/local/share/icons/Tango/16x16/actions/gtk-new.png was installed by package icons-tango-0.8.90_2

So I guess 
RUN_DEPENDS=	${LOCALBASE}/share/icons/Tango:x11-themes/icons-tango

I
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-01-09 01:46:10 UTC
Tested starts without problems only with deprecated warnings on 10.4
RUN_DEPENDS command was wrong, the right is
RUN_DEPENDS=	icons-tango>0:x11-themes/icons-tango
Comment 5 Walter Schwarzenfeld freebsd_triage 2018-06-04 12:58:11 UTC
Created attachment 193991 [details]
svn-diff-clamtk

Packed  all in a svn-diff added two RUN_DEPENCES.
Should also solve problems described here:
https://forums.freebsd.org/threads/clamtk-broken.66023/

Only tested with the port (not with poudriere yet).
Comment 6 Walter Schwarzenfeld freebsd_triage 2018-06-04 13:10:51 UTC
Created attachment 193992 [details]
svn-diff-clantk_v2

Correcting two lines cause of portlint
Comment 7 Walter Schwarzenfeld freebsd_triage 2018-06-04 13:14:33 UTC
Created attachment 193993 [details]
svn-diff-clamtk_v3

Removed ${PORTSDIR}. This was wrong.
Comment 8 Frank Harv 2018-06-05 03:19:14 UTC
I have clamtk version 5.25 working and I am working on the makefile now to update this.
I should have a patch ready in a few days for testing.
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2018-06-05 08:45:16 UTC
Created attachment 194012 [details]
patch-v4

This patch builds, but:

Icon 'gtk-new' not present in theme at /usr/local/lib/perl5/site_perl/ClamTk/GUI.pm line 285.
Comment 10 Walter Schwarzenfeld freebsd_triage 2018-06-05 13:16:50 UTC
Kurt, again
RUN_DEPENDS= icons-tango>0:x11-themes/icons-tango
Comment 11 Walter Schwarzenfeld freebsd_triage 2018-06-05 13:17:28 UTC
sorry is in the patch, I overlooked it.
Comment 12 Frank Harv 2018-06-05 20:52:08 UTC
In the programs perl library we need to {REINPLACE} this to add fixed up file path:
/usr/local/share/icons/gnome

GUI.pm
Line 36,37,38

$theme->append_search_path( '/usr/share/icons/gnome/24x24/actions' );
$theme->append_search_path( '/usr/share/icons/gnome/24x24/places' );
$theme->append_search_path( '/usr/share/icons/gnome/24x24/mimetypes' );
Comment 13 Walter Schwarzenfeld freebsd_triage 2018-06-05 22:58:05 UTC
Where to place?
/work/clamtk-e4c91f9/lib/GUI.pm

9 sub start_gui {
     30     $window = Gtk2::Window->new;
     31     $window->signal_connect(
     32         destroy => sub {
     33             $window->destroy;
     34             Gtk2->main_quit;
     35             TRUE;
     36         }
     37     );
Comment 14 Walter Schwarzenfeld freebsd_triage 2018-06-05 23:04:32 UTC
And there is no other GUI.pm.
Comment 15 Walter Schwarzenfeld freebsd_triage 2018-06-05 23:08:37 UTC
Maybe, it is only a problem of kde4 and xfce. I don't have the error that Kurt wrote (I havefvwm-crysal).
So it is a more complicated problem.
Comment 16 Walter Schwarzenfeld freebsd_triage 2018-06-05 23:26:48 UTC
There is a similar problem:
https://github.com/dave-theunsub/clamtk/issues/80

=> I had the same Problem on CentOS 7 today and was able to fix it by simply installing a package called 'gnome-icon-theme-legacy' which appears to be a split out of 'gnome-icon-theme'.
Comment 17 Frank Harv 2018-06-06 00:55:32 UTC
OK I see we are on the same page now and the PR has been changed to reflect the newest version 5.25. That was what I was referring to earlier. The newest version.

Everyone is correct though, I am finding that I installed something from Gnome with the icons.

I was wrong on my previous post.
On a fresh install of only xorg and xfce there is no /usr/local/share/icons/gnome directory.

So there is an additional package needed.
For 5.25 I am using this:

RUN_DEPENDS=	perl5>=5.26:lang/perl5.26 \
		p5-Glib2>=1.326:/devel/p5-Glib2 \
		p5-LWP-Protocol-https>=6.07_1:/perl/p5-LWP-Protocol-https \
		p5-Text-CSV>=1.95:/textproc/p5-Text-CSV \
		p5-JSON>=2.97.001:/converters/p5-JSON \
		p5-Locale-gettext>=1.07:/devel/p5-Locale-gettext \
		p5-Gtk2>=1.24992:x11-toolkits/p5-Gtk2\
Comment 18 Walter Schwarzenfeld freebsd_triage 2018-06-06 02:32:16 UTC
I think it one or both packages:
RUN_DEPENDS+= gnome-themes-standard>=3.0.0:x11-themes/gnome-themes-standard \
                gnome-icon-theme>=0:misc/gnome-icon-theme

maybe only the second.
Comment 19 Kurt Jaeger freebsd_committer freebsd_triage 2018-06-06 05:31:19 UTC
Committed, thanks. Only the second dependency was needed.
Comment 20 commit-hook freebsd_committer freebsd_triage 2018-06-06 05:31:57 UTC
A commit references this bug:

Author: pi
Date: Wed Jun  6 05:30:58 UTC 2018
New revision: 471827
URL: https://svnweb.freebsd.org/changeset/ports/471827

Log:
  security/clamtk: update 4.45 -> 5.25

  - new MASTER_SITE
  - fix dependencies
  - update WWW

  PR:		193908
  Submitted by:	pi, w.schwarzenfeld@utanet.at, dvwerks@cox.net
  Reported by:	nikos60@hushmail.com
  Approved by:	tj (maintainer timeout)

Changes:
  head/security/clamtk/Makefile
  head/security/clamtk/distinfo
  head/security/clamtk/pkg-descr
  head/security/clamtk/pkg-plist