Created attachment 147808 [details]
- Update mail/postgrey to the latest version
- Cleanup Makefile and plist a bit
- Remove pkg-install, plist handles it's functionality
- Add a patch from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=123468
Created attachment 147892 [details]
New patch without the fix for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=123468
I'm holding on resolution of 123468. The revised patch looks pretty good. I will either submit a final patch for commit or explicitly approve attachment 147892 [details] in a later message.
Yaa! Time flies when work keeps you busy! I'll will nail this down tonight. My apologies for the delay.
Created attachment 148791 [details]
(In reply to Darren Pilgrim from comment #5)
Please commit attachment 148791 [details].
- Update to v1.35;
- General clean up and update to current porting practices;
- Revise pkg-message to include a warning about potential information disclosures (see bug 123468);
- Move default pidfile location into the database dir to get around a minor nuissance issue where, due to permissions, postgrey fails to delete its pidfile from /var/run.
Created attachment 148793 [details]
patch with separate run directory
In my opinion it would be better if the package create a separate directory in /var/run for the pidfile. This dir can be used eventually for a unix domain socket too.
(In reply to TEUBEL György from comment #7)
There's precedent for that, so I'm fine with it. I do have a couple of nits about the modified patch, though:
- I would prefer the PG_* variables and their counterparts in SUB_LIST and PLIST_SUB in alphabetical order.
- The @dir() for PG_RUNDIR is missing its mode setting. It should be 750.
Okay, I'm not insisting on my exact patch, so I'm fine with your suggestions. Should I make a new patch or you will do it?
Just one sidenote: If the PG_RUNDIR has a mode of 750 then the "service postgrey status" command will not work as a regular user. But I think it's not a big problem.
Created attachment 148801 [details]
Ordered variables, and run directory permission
Looks good. Thanks Attachment 148801 [details] approved for commit.
The maintainer approved this.
There are no poudriere logs, but I'll move to patch-ready anyway. It looks ok with a very quick glance.
A commit references this bug:
Date: Wed Nov 5 17:35:40 UTC 2014
New revision: 372199
- Update to version 1.35
- Add LICENSE
- Remove pkg-install script, move directory creation to pkg-plist
- Use @sample keyword for config files
Submitted by: TEUBEL Gy?rg y<email@example.com>
Approved by: maintainer
--This line, and those below, will be ignored--
> Description of fields to fill in above: 76 columns --|
> PR: If a Bugzilla PR is affected by the change.
> Submitted by: If someone else sent in the change.
> Reviewed by: If someone else reviewed your modification.
> Approved by: If you needed approval for this commit.
> Obtained from: If the change is from a third party.
> MFC after: N [day[s]|week[s]|month[s]]. Request a reminder email.
> Relnotes: Set to 'yes' for mention in release notes.
> Security: Vulnerability reference (one per line) or description.
> Sponsored by: If the change was sponsored by an organization.
> Empty fields above will be automatically removed.
(In reply to commit-hook from comment #14)
Thank you for the commit. I guess you didn't see comment 6? It would have been nice to have the bit about the new warning message in the commit log where more people are going to see it more readily. Oh well.
Missed that one sorry. Still the info is in pkg-message and I would assume more users read this file on install than commit logs so hopefully this will
enough of a warning.
(In reply to Pawel Pekala from comment #16)
The goal was really to invoke a "commit references this bug" message for bug 123468. I did follow-up that bug, though, so maybe that will be enough.