Bug 194032 - iscsictl does not parse globals in /etc/iscsi.conf
Summary: iscsictl does not parse globals in /etc/iscsi.conf
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 10.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Edward Tomasz Napierala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-30 09:38 UTC by Benjamin Lutz
Modified: 2015-04-10 13:15 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Lutz 2014-09-30 09:38:50 UTC 
iscsictl does not parse global variables in /etc/iscsi.conf, any such variable causes an error. For example, after copying the config file from the EXAMPLE section of iscsi.conf(5) to /etc/iscsi.conf:

# iscsictl -Aa
iscsictl: error in configuration file at line 4 near 'port': syntax error
#

Looking at http://svnweb.freebsd.org/base/stable/10/usr.bin/iscsictl/parse.y?revision=262841&view=markup, it would appear that the parser has no rules for parsing global variables.
Comment 1 Edward Tomasz Napierala freebsd_committer freebsd_triage 2015-04-10 13:15:27 UTC 
I gave it some thought, and adding that functionality would require quite substantial changes to the parser.  Given it's not much of a problem to change the config file, and iscontrol is already obsolete...  I just fixed the iscsi.conf manual page to not mention globals.