Bug 194061 - games/djgame2: formally requesting review of revival of this port
Summary: games/djgame2: formally requesting review of revival of this port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-games (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-01 08:35 UTC by John Marino
Modified: 2014-10-31 10:13 UTC (History)
4 users (show)

See Also:
marino: maintainer-feedback? (games)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer 2014-10-01 08:35:41 UTC
I have asked Rusmir and games@ several times directly to answer tijl's question below, but no one is responding to mail lists or at #bsdports so I guess we need to get formal here.


tijl: "Online games with upstream gone.  Are you sure this port still works Google cannot find anything about "bluedj".


If there is no online service, the port should be removed again.



On 9/7/2014 14:18, Tijl Coosemans wrote:
> On Sun, 7 Sep 2014 11:34:28 +0000 (UTC) Rusmir Dusko <nemysis@FreeBSD.org> wrote:
>> Author: nemysis
>> Date: Sun Sep  7 11:34:27 2014
>> New Revision: 367521
>> URL: http://svnweb.freebsd.org/changeset/ports/367521
>> QAT: https://qat.redports.org/buildarchive/r367521/
>>
>> Log:
>>   - Readdition of games/djgame2 which was removed on r367488
>>   - Mastersite disappeared, mirror on my SF site
>>   - Transfer maintainership to games@ team
>>   - Add license GPLv2
>>
>> Added:
>>   head/games/djgame2/
>>   head/games/djgame2/Makefile   (contents, props changed)
>>   head/games/djgame2/distinfo   (contents, props changed)
>>   head/games/djgame2/files/
>>   head/games/djgame2/files/djgame2.desktop.in   (contents, props changed)
>>   head/games/djgame2/files/patch-Base__src__DJGraphicsChessTimerItem.cpp   (contents, props changed)
>>   head/games/djgame2/files/patch-Shisensho__src__DJGameRank.h   (contents, props changed)
>>   head/games/djgame2/files/patch-Shisensho__src__LLKPanelController.cpp   (contents, props changed)
>>   head/games/djgame2/files/startdjg.in   (contents, props changed)
>>   head/games/djgame2/pkg-descr   (contents, props changed)
>>   head/games/djgame2/pkg-plist   (contents, props changed)
>> Modified:
>>   head/games/Makefile
>>
>> Modified: head/games/Makefile
>> ==============================================================================
>> --- head/games/Makefile	Sun Sep  7 11:33:59 2014	(r367520)
>> +++ head/games/Makefile	Sun Sep  7 11:34:27 2014	(r367521)
>> @@ -187,6 +187,7 @@
>>      SUBDIR += defendguin
>>      SUBDIR += diameter
>>      SUBDIR += digger-vgl
>> +    SUBDIR += djgame2
>>      SUBDIR += dmjava
>>      SUBDIR += dodgindiamond2
>>      SUBDIR += domination
>>
>> Added: head/games/djgame2/Makefile
>> ==============================================================================
>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>> +++ head/games/djgame2/Makefile	Sun Sep  7 11:34:27 2014	(r367521)
>> @@ -0,0 +1,54 @@
>> +# Created by: Yinghong Liu <relaxbsd@gmail.com>
>> +# $FreeBSD$
>> +
>> +PORTNAME=	djgame2
>> +PORTVERSION=	3.2.0
>> +PORTREVISION=	4
>> +CATEGORIES=	games
>> +MASTER_SITES=	SF/nemysisfreebsdp/${CATEGORIES}/${PORTNAME}/
>> +DISTNAME=	source-${PORTVERSION}
>> +
>> +MAINTAINER=	games@FreeBSD.org
>> +COMMENT=	bluedj contains many popular online games
>
> Online games with upstream gone.  Are you sure this port still works?
> Google cannot find anything about "bluedj".
>


I'd actually like to hear the answer too.  Maybe somebody else from the
warm @games wing can answer this?

John
Comment 1 Bugzilla Automation freebsd_committer 2014-10-01 08:35:41 UTC
Auto-assigned to maintainer games@FreeBSD.org
Comment 2 John Marino freebsd_committer 2014-10-01 08:37:15 UTC
Adding tijl@, I'm sure he's still interested in the answer to his question.
Comment 3 Dmitry Marakasov freebsd_committer 2014-10-03 13:37:05 UTC
Can't you just test whether it works?
Comment 4 John Marino freebsd_committer 2014-10-03 13:41:22 UTC
(In reply to Dmitry Marakasov from comment #3)
> Can't you just test whether it works?

You know the same question applies to you, a member of the games@ team that is responsible for maintaining the port[1], right?

[1] I recognize that the adoption of the port might have been unilateral, but I have to assume Rusmir is functioning completely within the agreements of the games@ team.
Comment 5 John Marino freebsd_committer 2014-10-03 13:50:07 UTC
(In reply to Dmitry Marakasov from comment #3)
> Can't you just test whether it works?

And to be less squirrely: No, as this port was completely removed from the tree, the onus to make sure it works is on the person that revived the port.  Why should somebody else have to verify this?
Comment 6 commit-hook freebsd_committer 2014-10-06 23:41:06 UTC
A commit references this bug:

Author: amdmi3
Date: Mon Oct  6 23:40:53 UTC 2014
New revision: 370262
URL: https://svnweb.freebsd.org/changeset/ports/370262

Log:
  - Fix segfault (1)
  - Fix duplicate PORTREVISION

  PR:		194061 (1)
  Submitted by:	rndfax@yandex.ru
  MFH:		2014Q4

Changes:
  head/graphics/devil/Makefile
  head/graphics/devil/files/patch-src-IL__src__il_alloc.c
Comment 7 Dmitry Marakasov freebsd_committer 2014-10-07 00:03:12 UTC
Oops, wrong commit -> PR link.
Comment 8 commit-hook freebsd_committer 2014-10-31 09:46:54 UTC
A commit references this bug:

Author: amdmi3
Date: Fri Oct 31 09:46:43 UTC 2014
New revision: 371792
URL: https://svnweb.freebsd.org/changeset/ports/371792

Log:
  - Redeprecate: online servers are gone so the game is unplayable

  PR:		194061
  Investigated by:	Ruslan Makhmatkhanov

Changes:
  head/games/djgame2/Makefile