Bug 194133 - [MAINTAINER] Update security/pam_ocra to 1.1
Summary: [MAINTAINER] Update security/pam_ocra to 1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-04 06:02 UTC by Stefan Grundmann
Modified: 2014-10-12 17:47 UTC (History)
2 users (show)

See Also:

Attachments
pam_ocra-1.1.patch (932 bytes, patch)
2014-10-04 06:02 UTC, Stefan Grundmann 		no flags Details | Diff
pam_ocra-1.1.patch (1.53 KB, patch)
2014-10-04 19:38 UTC, Stefan Grundmann 		no flags Details | Diff
poudriere log (FreeBSD 10.1-RC1 amd64) (14.80 KB, text/x-log)
2014-10-08 19:19 UTC, Stefan Grundmann 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Grundmann 2014-10-04 06:02:44 UTC 
Created attachment 147953 [details]
pam_ocra-1.1.patch

update to pam_ocra-1.1 - this is a bugfix release

Changelog
---------

- 1.1:

  * fix timstamp_offset verification:
    broken termination condition in timstamp_offset verify loop did not
    account for timstamp_offset==0. The result was that verification would
    suceed for any timestamp.

  * fix counter_window and timstamp_offset verification:
    broken termination condition in counter_window verify loop did not
    account for counter_window==0. The result was that the verification
    would execute MAX_INT times before failing.

  * fix i368 builds:
    incorrect sign-compare and 64bit specific format string triggerd warnings
    which broke the build for i368 targets.
Comment 1 Stefan Grundmann 2014-10-04 08:07:41 UTC 
unfortunately the update does not fix build on OSVERSION=901000
(base openssl to old, gcc warnings)

i will rework the patch
Comment 2 Stefan Grundmann 2014-10-04 19:38:21 UTC 
Created attachment 147982 [details]
pam_ocra-1.1.patch
Comment 3 Stefan Grundmann 2014-10-04 20:01:41 UTC 
tested on
  + 10.1-BETA3     i386
  + 11.0-CURRENT   amd64
  + 9.3-RELEASE-p2 i386


updated Changelog
-----------------

- 1.1:

  * change ocra_tool(8) command line interface:
    - 'help' command removed
    - 'init' -P pinhash option added
    - 'init' -c option now also accepts hex counters
    - 'info' output format changed

  * fix ocra_tool counter input:
    the -c counter option did not work for the whole value range of the counter
    paramter.

  * fix gcc builds:
    which where broken due to (cast-qual, format, sign-compare, ...) warnings.

  * fix timstamp_offset verification:
    broken termination condition in timstamp_offset verify loop did not
    account for timstamp_offset==0. The result was that verification would
    suceed for any timestamp.

  * fix counter_window and timstamp_offset verification:
    broken termination condition in counter_window verify loop did not
    account for counter_window==0. The result was that the verification
    would execute MAX_INT times before failing.

  * fix i368 builds:
    incorrect sign-compare and 64bit specific format string triggerd warnings
    which broke the build for i368 targets.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-10-08 18:41:56 UTC 
Can you attach a poudriere log with stage-qa checks in it?
Comment 5 Stefan Grundmann 2014-10-08 19:19:09 UTC 
Created attachment 148110 [details]
poudriere log (FreeBSD 10.1-RC1 amd64)
Comment 6 John Marino freebsd_committer freebsd_triage 2014-10-08 21:23:33 UTC 
Very good.  I'm moving this to patch-ready status as a result.
Comment 7 Rodrigo Osorio freebsd_committer freebsd_triage 2014-10-12 17:47:24 UTC 
Commited, thanks.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-10-12 17:47:36 UTC 
A commit references this bug:

Author: rodrigo
Date: Sun Oct 12 17:47:17 UTC 2014
New revision: 370731
URL: https://svnweb.freebsd.org/changeset/ports/370731

Log:
  Update security/pam_ocra to 1.1

  PR:	ports/194133
  Submitted by:	sg2342@googlemail.com (maintainer)
  Approved by:	mentors (implicit)

Changes:
  head/security/pam_ocra/Makefile
  head/security/pam_ocra/distinfo