Bug 194192 - new port: www/py-bottle-cork
Summary: new port: www/py-bottle-cork
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-06 16:11 UTC by olivier
Modified: 2014-11-09 11:53 UTC (History)
1 user (show)

See Also:

Attachments
shar file of the py-bottle-cork (3.56 KB, text/plain)
2014-10-06 16:11 UTC, olivier 		no flags Details
poudriere log file (17.27 KB, text/plain)
2014-10-06 16:12 UTC, olivier 		no flags Details
new port version following marino@ advices (3.44 KB, text/plain)
2014-11-05 15:57 UTC, olivier 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description olivier 2014-10-06 16:11:36 UTC 
Created attachment 148033 [details]
shar file of the py-bottle-cork

Here is a new port: It's an authentication plugin for www/py-bottle.
Tested with poudriere testport and portlint.
Comment 1 olivier 2014-10-06 16:12:39 UTC 
Created attachment 148034 [details]
poudriere log file
Comment 2 John Marino freebsd_committer freebsd_triage 2014-10-31 19:01:16 UTC 
this looks good except for:

X.if ${PORT_OPTIONS:MSQLITE}
XRUN_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}sqlite3>0:${PORTSDIR}/databases/py-sqlite3
X.endif
X
X.if ${PORT_OPTIONS:MMONGODB}
XRUN_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}pymongo>0:${PORTSDIR}/databases/pymongo
X.endif
X
X.if ${PORT_OPTIONS:MSQLALCHEMY}
XRUN_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}sqlalchemy>0:${PORTSDIR}/databases/py-sqlalchemy
X.endif


should be:
SQLITE_RUN_DEPENDS=${PYTHON_PKGNAMEPREFIX}sqlite3>0:${PORTSDIR}/databases/py-sqlite3
MONGODB_RUN_DEPENDS=${PYTHON_PKGNAMEPREFIX}pymongo>0:${PORTSDIR}/databases/pymongo

etc.
See the porters handbook on options -- use the new style
Comment 3 olivier 2014-11-05 15:57:22 UTC 
Created attachment 149070 [details]
new port version following marino@ advices
Comment 4 John Marino freebsd_committer freebsd_triage 2014-11-05 18:22:27 UTC 
I only see two very minor issues:

1)
X%%PORTEXAMPLES%%@dir %%EXAMPLESDIR%%/example_conf
X%%PORTEXAMPLES%%@dir %%EXAMPLESDIR%%/views
X%%PORTEXAMPLES%%@dir %%EXAMPLESDIR%%

Those lines must be deleted

2) USES line is only tabbed once, it needs to line up with second tab.


I'll promote because next committer can fix this easily, but bonus points for fixing it before his has to.
Comment 5 olivier 2014-11-05 19:15:37 UTC 
Does only USES line needs to line up with second tab and not the other *_RUN_DEPENDS lines ?
Comment 6 John Marino freebsd_committer freebsd_triage 2014-11-09 11:39:51 UTC 
(In reply to olivier from comment #5)
> Does only USES line needs to line up with second tab and not the other
> *_RUN_DEPENDS lines ?

second tab.

Basically the guideline is 2nd tab for everything unless 3rd tab for a block makes sense (e.g. OPTION_* lines are often better using 3 tabs for the whole block)

1 tab is hardly ever used.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-11-09 11:44:10 UTC 
I'm just going to use PORTEXAMPLES=* and get rid of the pkg-plist completely.  It doesn't make sense to have a mixture of autogen and fixed plist, just autogen everything.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-11-09 11:52:49 UTC 
A commit references this bug:

Author: marino
Date: Sun Nov  9 11:51:57 UTC 2014
New revision: 372359
URL: https://svnweb.freebsd.org/changeset/ports/372359

Log:
  Add new port www/py-bottle-cork

  PR:		194192
  Submitted by:	Olivier (cochard.me)

  bottle-cork provides a simple set of methods to implement Authentication
  and Authorization in web applications based on Bottle.

Changes:
  head/www/Makefile
  head/www/py-bottle-cork/
  head/www/py-bottle-cork/Makefile
  head/www/py-bottle-cork/distinfo
  head/www/py-bottle-cork/pkg-descr
Comment 9 John Marino freebsd_committer freebsd_triage 2014-11-09 11:53:51 UTC 
Thanks, enjoy your port!