Created attachment 148162 [details]
Attached patch adds a check to use the -nox11 version of ImageMagick if OPTIONS_UNSET=X11 is set.
Without this patch the port would not build with poudriere:
====>> Computing deps for print/muttprint
====>> DEBUG: print/muttprint depends on converters/p5-Text-Iconv
====>> DEBUG: print/muttprint depends on devel/gmake
====>> DEBUG: print/muttprint depends on devel/p5-TimeDate
====>> DEBUG: print/muttprint depends on graphics/ImageMagick
====>> Error: Duplicated origin for ImageMagick-nox11-126.96.36.199_1,1: graphics/ImageMagick AND graphics/ImageMagick-nox11. Rerun with -vv to see which ports are depending on these.
maintainer did not get auto-CC'd, doing that now.
is OPTIONS_UNSET=X11 still supported officially?
Due to lack of feedback, maintainer approval is no longer required. I'm promoting the PR now.
This diff refers to PORTS_OPTIONS:MX11 but there's not option X11 in the port. If there was, the patch is okay.
So I think the patch needs to add the X11 option as well. Moving back to triage.
John, I didn't add an X11 option to the *port* because it's just a matter of handling the *dependencies*, not the port itself.
My patch makes it possible to build print/muttprint in an environment, where OPTIONS_UNSET=X11 is set globally (i.e. a poudriere build).
Please let me know if you think I should add a X11 option to the port regardlessly.
your code only works if X11 option is defined. As it stands now,
is what is executed in *ALL* cases.
Created attachment 149756 [details]
I've updated the patch to address the issue.
This looks ok, I'll promote it. However, it needs to have the PORTREVISION incremented (note to committer).
Actually, this is not ok.
It was assuming x11 before. this turns x11 into an option (fine), but has it off by default (not fine).
So it's missing OPTIONS_DEFAULT=x11, which I'll add.
A commit references this bug:
Date: Fri Nov 28 11:19:54 UTC 2014
New revision: 373545
print/muttprint: provide option to build it without X11 support
Submitted by: Frank Wall
Approved by: maintainer timeout
With my modification, this passed poudriere testing, thanks!