Bug 194337 - Latest perl and SVK does not work
Summary: Latest perl and SVK does not work
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-13 19:09 UTC by Hans Petter Selasky
Modified: 2015-10-11 08:28 UTC (History)
2 users (show)

See Also:

Attachments
patch to fix autouse issue (1021 bytes, patch)
2014-10-13 19:18 UTC, Kurt Jaeger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Petter Selasky freebsd_committer freebsd_triage 2014-10-13 19:09:52 UTC 
Hi,

When updating the system to the latest perl and SVK version in ports, I am seeing this:

 > svk diff .
autoused module List::Util has unique import() method at
/usr/local/lib/perl5/site_perl/5.16/SVK/Util.pm line 91.
BEGIN failed--compilation aborted at
/usr/local/lib/perl5/site_perl/5.16/SVK/Util.pm line 91.
Compilation failed in require at /usr/local/lib/perl5/5.16/autouse.pm
line 53.

System information:

> pkg info | grep -E "svk|perl"
p5-Log-Log4perl-1.42           Log4j implementation for Perl
p5-Scalar-List-Utils-1.35,1    Perl subroutines that would be nice to have in the perl core
p5-Storable-2.45               Persistency for perl data structures
perl5-5.16.3_11                Practical Extraction and Report Language
svk-2.2.3_3                    Distributed Version Control System

This fix makes it work again, not sure if it is right:

cd /usr/local/lib/perl5/site_perl/5.20/SVK
vi Util.pm

replace

use autouse 'List::Util'        => qw( max(@) );

with

use List::Util;

--HPS
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2014-10-13 19:13:34 UTC 
Reproduced on 10.0p9 with perl 5.20.

cd /usr/local/lib/perl5/site_perl/5.20/SVK
vi Util.pm
     
replace

use autouse 'List::Util'        => qw( max(@) );

with

use List::Util;

makes svk usable again.
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2014-10-13 19:18:40 UTC 
Created attachment 148277 [details]
patch to fix autouse issue
Comment 3 Enji Cooper freebsd_committer freebsd_triage 2014-10-13 19:23:18 UTC 
This project is not maintained anymore upstream.

I didn't find anything on Ubuntu, but I found something potentially interesting in
pkgsrc: http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/svk/ (as Kurt noted in
https://lists.freebsd.org/pipermail/freebsd-current/2014-October/052673.html , this might be hinting at another issue and SVK is just experiencing fallout from the autouse module bug).
Comment 4 John Marino freebsd_committer freebsd_triage 2014-11-01 15:31:02 UTC 
Given that the last time rafan@ has been involved with a commit to this port was back in 2010, I'd ask if he wants to release the port.  This PR timed out.

Technically Kurt has the right to commit his patch now.

However, based on Garrett's comment, I'm not moving it to patch ready.

Furthermore, based on the blowback Hans Petter got when he mentioned he used the tool, I'd say there's a discussion to be had to remove the port completely.

For now, I'm going to move this from "approval needed" back to "in discussion" and let you guys figure it out.
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2014-11-01 19:38:27 UTC 
(In reply to John Marino from comment #4)
> For now, I'm going to move this from "approval needed" back to "in
> discussion" and let you guys figure it out.

I've asked on ports@, and I asked hps and depending on the outcome...
Comment 6 Rong-En Fan freebsd_committer freebsd_triage 2014-11-22 14:43:49 UTC 
Sorry for the late. But feel free to take over the ports if anyone is interested in keeping it running on FreeBSD. The upstream stopped the development a long time ago. I don't know if it's still that useful nowadays.
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-11 08:28:05 UTC 
This change was committed in PR 198820