Created attachment 148282 [details]
SVN diff for games/pingus 0.7.6
I have patched the games/pingus port from 0.7.2 to 0.7.6 ;
Here is a summary of the changes via 'svn status':
I e-mailed these changes to the port maintainer, Alonso (acm) 5 weeks ago and didn't hear anything back, and I don't see an existing PR for this version.
I have attached an svn diff with my changes versus head.
The new version requires a compiler which supports the c++0x standard; for FreeBSD versions <= 9.3 , they will receive an IGNORE trying to build this port with a suggestion to install a newer version of gcc/clang from the ports tree.
I have built and installed this version on amd64 VM's 10.0 and 9.3 successfully (on 9.3 I upgraded CC and CXX to gcc4.6) and also tested it on redports with the expected results.
I also cleaned up a few things so that portlint only lists two inconsequential warnings.
Auto-assigned to maintainer acm@FreeBSD.org
predictably, this timed out.
I'm moving to patch-ready but I did notice that PORTREVISION was assigned "1" for some inexplicable reason. That line needs to be remove.
Created attachment 148839 [details]
SVN diff for pingus 0.7.6 no PORTREVISION
My mistake, I didn't read the porter's handbook close enough. I thought all PORTREVISIONs started at 1, not 0.
PORTREVISION has been removed; new diff attached.
actually, I didn't look at this carefully when I "auto approved" this.
Now that I am looking at it, this compiler hack doesn't smell right.
Q1) Why not specify "USES+= compilers:c++0x" instead?
Q2) Better yet, why not patch it to work on c++11 ? What is it, a tr1 problem?
also when this gets sorted out, I'm going to reset the maintainership of the port to "ports@FreeBSD.org" unless you want to volunteer.
I'm moving this back to triage -- we've waited 10 days for Ben's reply and are still waiting.
A commit references this bug:
Date: Sat Nov 22 19:36:28 UTC 2014
New revision: 373097
games/pingus: Reset maintainer, unmask install cmds while here
I reset the maintainer and cleaned up the port a bit.
Unfortunately, that means the patch here doesn't apply anymore, but I think it needed another submission anyway (see waiting on OP response)
I'm tired of seeing this on my list, so I'm de-CC'ing myself.
Patch from 194711 committed + LICENSE added.