Bug 194363 - [patch] lang/lua-mode.el references obsolete last-command-char
Summary: [patch] lang/lua-mode.el references obsolete last-command-char
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-15 03:27 UTC by Christopher Hall
Modified: 2014-11-09 10:08 UTC (History)
1 user (show)

See Also:


Attachments
Add a line to cmakefile to sed s/last-command-char/last-command-event/g (441 bytes, patch)
2014-10-15 03:27 UTC, Christopher Hall
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Hall 2014-10-15 03:27:09 UTC
Created attachment 148320 [details]
Add a line to cmakefile to sed s/last-command-char/last-command-event/g

Latest EMACS removes last-command-char so need to patch the lua-mode.el to change this to last-command-event.

Attached is a patch for Makefile that does the patching in the staging directory directly in the do-install rule.

Not sure if this is the correct way, but the port does not build anything it simply populates the staging area; so could not add a standard patch file. 

Only tested with: emacs24-24.3_7,3
Comment 1 John Marino freebsd_committer 2014-11-01 09:50:41 UTC
This port is unmaintained, so I'll just promote the PR.
However, this change requires a PORTREVISION bump which the patch does not include.
Comment 2 commit-hook freebsd_committer 2014-11-09 10:06:38 UTC
A commit references this bug:

Author: marino
Date: Sun Nov  9 10:06:15 UTC 2014
New revision: 372350
URL: https://svnweb.freebsd.org/changeset/ports/372350

Log:
  lang/lua-mode.el: Remove reference to obsolete last-command-char

  While here, clean up the port and remove @dirrm* lines

  PR:		194363
  Submitted by:	Christopher Hall

Changes:
  head/lang/lua-mode.el/Makefile
Comment 3 John Marino freebsd_committer 2014-11-09 10:08:46 UTC
Thanks!