Bug 194367 - [MAINTAINER] japanese/ebnetd: use @dir to handle ${EBNET_RUNDIR} in pkg-plist
Summary: [MAINTAINER] japanese/ebnetd: use @dir to handle ${EBNET_RUNDIR} in pkg-plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-15 04:31 UTC by Yasuhiro Kimura
Modified: 2014-10-18 07:16 UTC (History)
1 user (show)

See Also:

Attachments
Use @dir to handle ${EBNET_RUNDIR} in pkg-plist. (578 bytes, patch)
2014-10-15 04:31 UTC, Yasuhiro Kimura 		no flags Details | Diff
Updated patch. (719 bytes, patch)
2014-10-16 23:22 UTC, Yasuhiro Kimura 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2014-10-15 04:31:08 UTC 
Created attachment 148324 [details]
Use @dir to handle ${EBNET_RUNDIR} in pkg-plist.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-10-16 08:52:49 UTC 
should this line:
@dir %%EBNETD_RUNDIR%%

really be

@dir(,,755) %%EBNETD_RUNDIR%%

??

(The original line was "@exec mkdir -m 0755 -p %%EBNETD_RUNDIR%%")


I'm not sure.  755 might be the default anyway so the extra arguments aren't needed.  You tell me.
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-10-16 23:22:33 UTC 
Created attachment 148383 [details]
Updated patch.

Thank you for pointing out. I fixed pkg-plist and also changed so it uses @sample to install configuration file. So please commit updated patch instead of original one.

Regards.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-10-17 08:49:02 UTC 
okay.  It will also need a PORTREVISION bump due to @sample change.  I'll take care of that.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-10-18 06:57:10 UTC 
it failed stage-qa checks.  Five files need shebangfile.  I'll fix it if it is easy to do.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-10-18 07:09:01 UTC 
shebangfix won't fix it.

I had to add "CONFIGURE_ENV= PERL=${PREFIX}/bin/perl" to fix it.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-10-18 07:13:50 UTC 
A commit references this bug:

Author: marino
Date: Sat Oct 18 07:13:33 UTC 2014
New revision: 371094
URL: https://svnweb.freebsd.org/changeset/ports/371094

Log:
  japanese/ebnetd: Remove @dirrm, use @sample, use @dir()

  The stage-qa checks said 5 files needed perl shebang fixed, but
  USE=shebangfix won't fix it.  The value of PERL was defined for the
  configure target to fix it.  However, a run depends on perl was not
  added as the affected files are probably optional scripts.

  PR:		194367
  Submitted by:	maintainer (Yasuhiro KIMURA)

Changes:
  head/japanese/ebnetd/Makefile
  head/japanese/ebnetd/pkg-plist
Comment 7 John Marino freebsd_committer freebsd_triage 2014-10-18 07:16:35 UTC 
during installation, it had a problem updating /etc/services file and created a /etc/services.bak which got registered as a "leftover" file.

This was on FreeBSD 10 poudriere jail.  You might want to see if you can replicate that.  It's a minor issue but maybe indicates the port won't function right.