Bug 194449 - [patch] net/dhcpcd: dhcpcd.conf overwritten on package install
Summary: [patch] net/dhcpcd: dhcpcd.conf overwritten on package install
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-18 18:27 UTC by guyyur
Modified: 2014-11-04 18:00 UTC (History)
2 users (show)

See Also:
guyyur: maintainer-feedback? (roy)

Attachments
Use @sample for the conf file (831 bytes, patch)
2014-10-18 18:27 UTC, guyyur 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description guyyur 2014-10-18 18:27:18 UTC 
Created attachment 148435 [details]
Use @sample for the conf file

Installing the dhcpcd package will overwrite a custom dhcpcd.conf
if it exists in /usr/local/etc/dhcpcd.conf before the package is installed.

Attached patch to rename the file to .sample in the stage dir and use @sample.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-10-18 18:27:18 UTC 
Maintainer CC'd
Comment 2 roy 2014-10-20 13:48:34 UTC 
This patch looks fine!
Comment 3 John Marino freebsd_committer freebsd_triage 2014-10-31 18:48:51 UTC 
maintainer has approved the patch, moving to patch-ready pool.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-11-04 18:00:53 UTC 
A commit references this bug:

Author: pawel
Date: Tue Nov  4 17:59:55 UTC 2014
New revision: 372160
URL: https://svnweb.freebsd.org/changeset/ports/372160

Log:
  - Update to version 6.5.1, add pkg-message [1]
  - Prevent config overwrite by using @sample keyword [2]

  PR:		194486 [1], 194449 [2]
  Submitted by:	maintainer [1], guyyur@gmail.com [2]
  Approved by:	maintainer [2]

Changes:
  head/net/dhcpcd/Makefile
  head/net/dhcpcd/distinfo
  head/net/dhcpcd/files/patch-dhcpcd.conf
  head/net/dhcpcd/pkg-message
  head/net/dhcpcd/pkg-plist