Bug 194532 - [PATCH] graphics/gimp-app not shown `brush outline'
Summary: [PATCH] graphics/gimp-app not shown `brush outline'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-22 16:04 UTC by Kalten
Modified: 2014-12-09 15:06 UTC (History)
1 user (show)

See Also:
kalten: maintainer-feedback? (gnome)

Attachments
patch-brush-outline.diff (1.63 KB, patch)
2014-10-22 16:07 UTC, Kalten 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kalten 2014-10-22 16:04:35 UTC 
Gimp 2.8.10 has a nasty error that makes working hard:
(see https://bugzilla.gnome.org/show_bug.cgi?id=719593#c4)
The outline of the brush tools is not shown
(“Edit”/“Preferences” there “Image Windows” and there “Show brush outline”). It is about pencile, paintbrush, eraser, airbrush, clone, healing, blur/sharpen, smudge, etc.

To correct it there are two possible solutions:

Variant 1:
update gimp with all its sub ports to 2.8.14
(Too much for my person to do, I think)

Variant 2:
The Patch mentioned in the Gimp-Bug above. One can find it (amongst others) e.g. there https://lists.macosforge.org/pipermail/macports-changes/2013-December/098857.html
I have taken out the relevant part and made a patch (see the attachment in my following comment—I want to enter the FreeBSD Bug number in a comment in the Makefile).

My patch (on top of r371335 of the ports tree) will add an if-clause in the Makefile of graphics/gimp-app that will apply the (also included) patch »files/2_8_10_patch-brush-outline-not-displayed-bz719593.diff« iff the ${PORTVERSION} == 2.8.10.
There will be a comment in the Makefile telling the person who will update gimp to a newer version to remove these lines and the mentioned patch file.

Regards,
 Kalten
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-10-22 16:04:35 UTC 
Auto-assigned to maintainer gnome@FreeBSD.org
Comment 2 Kalten 2014-10-22 16:07:32 UTC 
Created attachment 148562 [details]
patch-brush-outline.diff
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-12-09 15:05:13 UTC 
A commit references this bug:

Author: kwm
Date: Tue Dec  9 15:04:24 UTC 2014
New revision: 374400
URL: https://svnweb.freebsd.org/changeset/ports/374400

Log:
  Update to 2.8.14.

  This fixes a bug in the brush tool [1]
  Use new GIMP master site macro.
  Drop :keepla from USES=libtool
  Remove intltool, libartlgpl2 and gnomehier from USE_GNOME.
    Intlhack already implies intltool, gnomehier is obsolete now that pkg
    handles directories and libartlgpl2 is unused.

  PR:		194532 [1]
  Submitted by:	Kalten <kalten@gmx.at> [1]

Changes:
  head/graphics/gimp/Makefile
  head/graphics/gimp-app/Makefile
  head/graphics/gimp-app/distinfo
  head/graphics/gimp-app/files/patch-app_text_gimpfont.c
  head/graphics/gimp-app/pkg-plist
  head/graphics/py-gimp/Makefile
  head/graphics/py-gimp/pkg-plist