Bug 194542 - New port: devel/git-extras sub-commands for repo summary, repl, changelog population, etc
Summary: New port: devel/git-extras sub-commands for repo summary, repl, changelog pop...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 02:21 UTC by Igor Ostapenko
Modified: 2014-11-08 11:38 UTC (History)
1 user (show)

See Also:


Attachments
git-extras-2.1.0.shar (5.13 KB, text/plain)
2014-10-23 02:21 UTC, Igor Ostapenko
no flags Details
git-extras-2.1.0.shar (5.10 KB, text/plain)
2014-11-07 23:23 UTC, Igor Ostapenko
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Ostapenko freebsd_committer freebsd_triage 2014-10-23 02:21:38 UTC
Created attachment 148569 [details]
git-extras-2.1.0.shar
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2014-11-07 18:31:46 UTC
Isn't SHEBANG_FILES=bin/git-* an overkill? It seems to me
that only bin/git-squash has wrong (bin/bash) shebang here.
Also @dir etc/bash_completion.d is not needed in pkg-plist, pkg
manages directories automatically if they contain files installed
by the port/package. Besides those two small issues looks good. Thanks.
Comment 2 Igor Ostapenko freebsd_committer freebsd_triage 2014-11-07 23:23:49 UTC
Created attachment 149174 [details]
git-extras-2.1.0.shar
Comment 3 Igor Ostapenko freebsd_committer freebsd_triage 2014-11-07 23:25:59 UTC
Thank you for the comments. Please, help me with the following questions:
1) I think bin/git-* was used for future releases, not to re-check bin files again. Could you please outline possible harm if it's kept so, additional time spending?
2) pkg-plist was generated with 'make makeplist', is it outdated way?

Anyway, please check new shar file with your points considered.
Comment 4 Pawel Pekala freebsd_committer freebsd_triage 2014-11-08 10:34:49 UTC
> 1) I think bin/git-* was used for future releases, not to re-check bin files  > again. Could you please outline possible harm if it's kept so, additional time > spending?

Using globals here when only one file needs to be corrected is harder to
review later, it gives wrong impression that more files need to be checked.
It got me scratching my head for a while when I saw most of those file were
using /bin/sh for shebang.

As for the future you can use make stage-qa which will find all bad shebangs
for you.

> 2) pkg-plist was generated with 'make makeplist', is it outdated way?

No it's recommended way, but it's not 100% accurate in all cases so human
sanity checking is advised afterwards.

[blaviken@~/ports/devel/git-extras]% make makeplist
/you/have/to/check/what/makeplist/gives/you
[..]
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-11-08 11:34:43 UTC
A commit references this bug:

Author: pawel
Date: Sat Nov  8 11:34:39 UTC 2014
New revision: 372317
URL: https://svnweb.freebsd.org/changeset/ports/372317

Log:
  Additional Git sub-commands:
   - repository summary
   - author commit percentages
   - changelog population
   - shortcuts for branching/tagging/releasing
   - GitHub related shortcuts
   - repl (read-eval-print-loop), an interactive mode
   - and more...

  WWW: https://github.com/tj/git-extras/

  PR:		ports/194542
  Submitted by:	Igor Ostapenko <igor.ostapenko@gmail.com>

Changes:
  head/devel/Makefile
  head/devel/git-extras/
  head/devel/git-extras/Makefile
  head/devel/git-extras/distinfo
  head/devel/git-extras/files/
  head/devel/git-extras/files/patch-Makefile
  head/devel/git-extras/pkg-descr
  head/devel/git-extras/pkg-plist
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-11-08 11:37:44 UTC
A commit references this bug:

Author: pawel
Date: Sat Nov  8 11:37:23 UTC 2014
New revision: 45953
URL: https://svnweb.freebsd.org/changeset/doc/45953

Log:
  For devel/git-extras

  PR:		194542

Changes:
  head/en_US.ISO8859-1/articles/contributors/contrib.additional.xml
Comment 7 Pawel Pekala freebsd_committer freebsd_triage 2014-11-08 11:38:51 UTC
Committed with minor tweaks, thanks!