Created attachment 148569 [details] git-extras-2.1.0.shar
Isn't SHEBANG_FILES=bin/git-* an overkill? It seems to me that only bin/git-squash has wrong (bin/bash) shebang here. Also @dir etc/bash_completion.d is not needed in pkg-plist, pkg manages directories automatically if they contain files installed by the port/package. Besides those two small issues looks good. Thanks.
Created attachment 149174 [details] git-extras-2.1.0.shar
Thank you for the comments. Please, help me with the following questions: 1) I think bin/git-* was used for future releases, not to re-check bin files again. Could you please outline possible harm if it's kept so, additional time spending? 2) pkg-plist was generated with 'make makeplist', is it outdated way? Anyway, please check new shar file with your points considered.
> 1) I think bin/git-* was used for future releases, not to re-check bin files > again. Could you please outline possible harm if it's kept so, additional time > spending? Using globals here when only one file needs to be corrected is harder to review later, it gives wrong impression that more files need to be checked. It got me scratching my head for a while when I saw most of those file were using /bin/sh for shebang. As for the future you can use make stage-qa which will find all bad shebangs for you. > 2) pkg-plist was generated with 'make makeplist', is it outdated way? No it's recommended way, but it's not 100% accurate in all cases so human sanity checking is advised afterwards. [blaviken@~/ports/devel/git-extras]% make makeplist /you/have/to/check/what/makeplist/gives/you [..]
A commit references this bug: Author: pawel Date: Sat Nov 8 11:34:39 UTC 2014 New revision: 372317 URL: https://svnweb.freebsd.org/changeset/ports/372317 Log: Additional Git sub-commands: - repository summary - author commit percentages - changelog population - shortcuts for branching/tagging/releasing - GitHub related shortcuts - repl (read-eval-print-loop), an interactive mode - and more... WWW: https://github.com/tj/git-extras/ PR: ports/194542 Submitted by: Igor Ostapenko <igor.ostapenko@gmail.com> Changes: head/devel/Makefile head/devel/git-extras/ head/devel/git-extras/Makefile head/devel/git-extras/distinfo head/devel/git-extras/files/ head/devel/git-extras/files/patch-Makefile head/devel/git-extras/pkg-descr head/devel/git-extras/pkg-plist
A commit references this bug: Author: pawel Date: Sat Nov 8 11:37:23 UTC 2014 New revision: 45953 URL: https://svnweb.freebsd.org/changeset/doc/45953 Log: For devel/git-extras PR: 194542 Changes: head/en_US.ISO8859-1/articles/contributors/contrib.additional.xml
Committed with minor tweaks, thanks!