Bug 194596 - [PATCH] graphics/luminance-qt5: Add missing dependencies
Summary: [PATCH] graphics/luminance-qt5: Add missing dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
: 194595 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-10-25 13:58 UTC by Raphael Kubo da Costa
Modified: 2014-11-10 22:20 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-10-25 13:58:29 UTC 
The attached patch adds some missing build and runtime dependencies to luminance-qt5:
 * USES=pkgconfig was missing so exiv2 detection was broken, for example
 * USE_QT5=declarative and USE_QT5=printsupport were missing, and the latter was required for the port to build correctly with Qt 5.3.2 (see bug 194566). I've added an upstream commit to properly detect and use PrintSupport in the build process as well.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-10-25 13:58:29 UTC 
Maintainer CC'd
Comment 2 Hannes Hauswedell 2014-10-25 21:47:04 UTC 
Sure, feel free to commit.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-10-25 23:05:44 UTC 
A commit references this bug:

Author: rakuco
Date: Sat Oct 25 23:04:54 UTC 2014
New revision: 371492
URL: https://svnweb.freebsd.org/changeset/ports/371492

Log:
  Add missing dependencies.

  * USES=pkgconfig was missing so exiv2 detection was broken, for example.
  * USE_QT5=declarative and USE_QT5=printsupport were missing, and the latter
    is required for the port to build correctly with the upcoming Qt 5.3.2.
    I've added an upstream commit to properly detect and use PrintSupport in
    the build process as well.

  PR:		194596
  Approved by:	Hannes Hauswedell <h2+fbsdports@fsfe.org> (maintainer)

Changes:
  head/graphics/luminance-qt5/Makefile
  head/graphics/luminance-qt5/files/
  head/graphics/luminance-qt5/files/patch-git_07e36ef8
Comment 4 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-11-10 22:20:01 UTC 
*** Bug 194595 has been marked as a duplicate of this bug. ***