Created attachment 148720 [details] Upgrade patch Hello Dovecot users, It's been about 5 months since the last Pigeonhole release, so it is high time for a new one. However, the main reason to make a release now is the fact that Dovecot v2.2.15 has one change that causes problems with the previous release of Pigeonhole. Unlike recent earlier releases, this release has a few big new features. Most notably, I implemented a generic Sieve script storage framework. This means that it is now relatively easy to implement a storage driver to retrieve Sieve scripts from a location other than the file system. An important effect of this new implementation is that these alternative storage locations can also be used with sieve_before/sieve_after. Also, storing Sieve scripts there using ManageSieve is also possible, provided that the driver provides an implementation. I used the new framework to implement an LDAP storage driver. However, it is read-only, which means that it doesn't currently provide ManageSieve support. Several bugs were fixed. The most nasty ones were related to the doveadm-sieve plugin (which is one of the reasons why this release took so long). The new script storage driver framework entailed large changes in this plugin, so many of these problems were addressed implicitly. Hopefully, all problems are solved now. Changelog v0.4.4: * Added support for Japanese mail addresses with dots at non-standard places in localpart. * Changed handling of ENOSPACE into a normal temporary failure and added handling of ENOQUOTA as a user error. * Restructured result execution, so that all actions which involve mail storage are always committed before all others. + Implemented support for generic Sieve storages. Using alternative storages now also possible for sieve_before/sieve_after. + Implemented storage driver for retrieving Sieve scripts from LDAP. This currently cannot be used with ManageSieve. + Implemented sieve_redirect_envelope_from setting, which allows configuring the envelope sender of redirected messages. - Fixed handling of mail storage errors occurring while evaluating the input message. - managesieve-login: - Removed bogus ALERT response code returned for AUTHENTICATE command. - Fixed handling of invalid initial response argument to AUTHENTICATE command. - Fixed handling of stream errors in lexical scanner. - Fixed handling of SMTP errors. Permanent and temporary errors were mixed up. - Fixed several problems reported by CLang 3.4. - duplicate extension: Fixed erroneous compile error about conflicting tags when `:handle' argument was used last. - relational extension: Fixed error handling of `:value' match. - editheader extension: Fixed header unfolding and header iteration. - mailbox extension: Fixed the `:create' tag, which erroneously subscribed an existing folder. - extprograms plugin: Fixed handling of error codes. - doveadm-sieve plugin: Fixed several bugs. Synchronization of symbolic link in the file storage should now also work properly. The release is available as follows: http://pigeonhole.dovecot.org/releases/2.2/dovecot-2.2-pigeonhole-0.4.4.tar.gz http://pigeonhole.dovecot.org/releases/2.2/dovecot-2.2-pigeonhole-0.4.4.tar.gz.sig Refer to http://pigeonhole.dovecot.org and the Dovecot v2.x wiki for more information. Have fun testing this new release and don't hesitate to notify me when there are any problems.
Maintainer CC'd
Created attachment 148809 [details] 0.4.5 patch 0.4.5 patch
Author released 0.4.5. Hello Dovecot users, Unfortunately, Pigeonhole v0.4.4 had a rather big issue with error handling and the execution of the implicit keep. This problem presented itself for example when users exceeded their quota. This did not result in the proper rejection message. This is why I quickly release a new version. Changelog v0.4.5: + Added a Pigeonhole version banner to doveconf output. This way, future bug reports will also include Pigeonhole version information. - Fixed handling of implicit keep. Last version erroneously reported that implicit keep succeeded after an earlier failure, while it in fact had failed. Particularly occurred for mailbox quota errors. - Fixed segfault occurring on SunOS systems when there is no active script. The release is available as follows: http://pigeonhole.dovecot.org/releases/2.2/dovecot-2.2-pigeonhole-0.4.5.tar.gz http://pigeonhole.dovecot.org/releases/2.2/dovecot-2.2-pigeonhole-0.4.5.tar.gz.sig Refer to http://pigeonhole.dovecot.org and the Dovecot v2.x wiki for more information. Have fun testing this new release and don't hesitate to notify me when there are any problems. Regards, there is a patch needed as well, included in the patch svn add files after running the patch.
Created attachment 148810 [details] 0.4.5 patch -- with the patch file this time
To Attila Nagy (maintainer), You have two consecutive, recent PR timeouts on this port. If this PR times out as well, I'm resetting the maintainership to ports@ Larry, if you hear nothing on this PR after 2 weeks has passed, then actively ping me and I'll take some action.
John, If this times out, I can take it :)
Created attachment 148943 [details] upgrade to 0.4.6 patch Author integrated the patch in the previous attachment, and that's the only change. use THIS patch, and don't add the files/patch-Makefile.am file from the previous one.
Maintainer timed out again. to the next committer: Please change the maintainer to Larry Rosenman (ler@lerctr.org) (Larry, it's best if you update the patch to make the MAINTAINER change yourself and not rely on this comment). I'm promoting this to the patch-ready pool.
Created attachment 149331 [details] update to 0.4.6/change maintainer to self
make check-plist worked fine. doing poudriere build tests right now.
A commit references this bug: Author: pi Date: Thu Nov 13 18:58:43 UTC 2014 New revision: 372535 URL: https://svnweb.freebsd.org/changeset/ports/372535 Log: mail/dovecot2-pigeonhole: 0.4.3 -> 0.4.6 - submitter takes maintainership Changes: 0.4.4: - Added support for Japanese mail addresses with dots at non-standard places in localpart. - Changed handling of ENOSPACE into a normal temporary failure and added handling of ENOQUOTA as a user error. - Restructured result execution, so that all actions which involve mail storage are always committed before all others. - Implemented support for generic Sieve storages. Using alternative storages now also possible for sieve_before/sieve_after. - Implemented storage driver for retrieving Sieve scripts from LDAP. This currently cannot be used with ManageSieve. - Implemented sieve_redirect_envelope_from setting, which allows configuring the envelope sender of redirected messages. - Fixed handling of mail storage errors occurring while evaluating the input message. - managesieve-login: - Removed bogus ALERT response code returned for AUTHENTICATE command. - Fixed handling of invalid initial response argument to AUTHENTICATE command. - Fixed handling of stream errors in lexical scanner. - Fixed handling of SMTP errors. Permanent and temporary errors were mixed up. - Fixed several problems reported by CLang 3.4. - duplicate extension: Fixed erroneous compile error about conflicting tags when `:handle' argument was used last. - relational extension: Fixed error handling of `:value' match. - editheader extension: Fixed header unfolding and header iteration. - mailbox extension: Fixed the `:create' tag, which erroneously subscribed an existing folder. - extprograms plugin: Fixed handling of error codes. - doveadm-sieve plugin: Fixed several bugs. Synchronization of symbolic link in the file storage should now also work properly. 0.4.5: - Added a Pigeonhole version banner to doveconf output. This way, future bug reports will also include Pigeonhole version information. - Fixed handling of implicit keep. Last version erroneously reported that implicit keep succeeded after an earlier failure, while it in fact had failed. Particularly occurred for mailbox quota errors. - Fixed segfault occurring on SunOS systems when there is no active script. 0.4.6: - ports-related change integrated upstream PR: 194645 Submitted by: Larry Rosenman <ler@lerctr.org> Approved by: maintainer (timeout) Changes: head/mail/dovecot2-pigeonhole/Makefile head/mail/dovecot2-pigeonhole/distinfo head/mail/dovecot2-pigeonhole/pkg-plist
Committed, thanks.