Bug 194670 - [maintainer patch update] logstash-1.4.2 (port update clobbers existing configuration files)
Summary: [maintainer patch update] logstash-1.4.2 (port update clobbers existing confi...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Matthew Seaman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-28 18:47 UTC by Enrico M. Crisostomo
Modified: 2014-10-29 07:16 UTC (History)
1 user (show)

See Also:
enrico.m.crisostomo: maintainer-feedback+

Attachments
logstash-1.4.2 - Patch (16.44 KB, patch)
2014-10-28 18:48 UTC, Enrico M. Crisostomo 		no flags Details | Diff
poudriere testport -o sysutils/logstash output (13.74 KB, text/plain)
2014-10-28 18:48 UTC, Enrico M. Crisostomo 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrico M. Crisostomo 2014-10-28 18:47:39 UTC 
The current version of the port may clobber existing configuration files, since they're not installed using the @sample directive in pkg-plist.

This update:

  * Removes files/logstash.conf.
  * Moves files/elasticsearch.yml to files/elasticsearch.yml.sample.
  * Installs @sample files/logstash.conf.sample.
  * Installs @sample files/elasticsearch.yml.sample.

SVN changes:

M   Makefile
D   files/logstash.conf
M   files/logstash.conf.sample
D   files/elasticsearch.yml
A   files/elasticsearch.yml.sample
M   pkg-plist

Attachments:

  * logstash-1.4.2.diff.
  * poudriere testport output.
Comment 1 Enrico M. Crisostomo 2014-10-28 18:48:02 UTC 
Created attachment 148744 [details]
logstash-1.4.2 - Patch
Comment 2 Enrico M. Crisostomo 2014-10-28 18:48:30 UTC 
Created attachment 148745 [details]
poudriere testport -o sysutils/logstash output
Comment 3 Matthew Seaman freebsd_committer freebsd_triage 2014-10-28 19:39:46 UTC 
For future reference: any time you modify the port in such a way that it changes the installed package you should bump PORTREVISION (or add PORTREVISION = 1 if there isn't one yet.) Changing the pkg-plist is pretty much an automatic PORTREVISION update.

I'll add it for you, just this once.
Comment 4 Enrico M. Crisostomo 2014-10-28 19:57:23 UTC 
Thanks for the clarification Matt.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-10-29 07:14:55 UTC 
A commit references this bug:

Author: matthew
Date: Wed Oct 29 07:14:47 UTC 2014
New revision: 371663
URL: https://svnweb.freebsd.org/changeset/ports/371663

Log:
  Fix handling of config files.

  PR:		194670
  Submitted by:	enrico.m.crisostomo@gmail.com (maintainer)

Changes:
  head/sysutils/logstash/Makefile
  head/sysutils/logstash/files/elasticsearch.yml
  head/sysutils/logstash/files/logstash.conf
  head/sysutils/logstash/files/logstash.conf.sample
  head/sysutils/logstash/pkg-plist