Bug 194692 - x11-drivers/xf86-video-intel Compilation failed unexpectedly
Summary: x11-drivers/xf86-video-intel Compilation failed unexpectedly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-29 18:18 UTC by Helge Oldach
Modified: 2014-11-02 10:00 UTC (History)
3 users (show)

See Also:
freebsd: maintainer-feedback? (x11)


Attachments
transcript of 'make all' (51.53 KB, text/plain)
2014-10-29 18:18 UTC, Helge Oldach
no flags Details
/usr/local/include/xorg/fb.h (48.56 KB, text/x-csrc)
2014-10-29 18:56 UTC, Helge Oldach
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2014-10-29 18:18:51 UTC
Created attachment 148774 [details]
transcript of 'make all'

2.21.15_5 version

make terminates with:

/usr/local/include/xorg/fb.h:837: warning: redundant redeclaration of 'fbGetWinPrivateKey'
/usr/local/include/xorg/fb.h:611: warning: previous declaration of 'fbGetWinPrivateKey' was here
*** [intel_batchbuffer.lo] Error code 1

Stop in /usr/obj/usr/ports/x11-drivers/xf86-video-intel/work/xf86-video-intel-2.21.15/src/uxa.
*** [all-recursive] Error code 1

Stop in /usr/obj/usr/ports/x11-drivers/xf86-video-intel/work/xf86-video-intel-2.21.15/src.
*** [all-recursive] Error code 1

Stop in /usr/obj/usr/ports/x11-drivers/xf86-video-intel/work/xf86-video-intel-2.21.15.
*** [all] Error code 1

Stop in /usr/obj/usr/ports/x11-drivers/xf86-video-intel/work/xf86-video-intel-2.21.15.
*** [do-build] Error code 1

Stop in /usr/ports/x11-drivers/xf86-video-intel.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-10-29 18:18:51 UTC
Auto-assigned to maintainer x11@FreeBSD.org
Comment 2 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2014-10-29 18:48:02 UTC
Hi!

Two declaration in the same header is really strange.

Could you please indicate the version of xorg-server you have? And could you please attach /usr/local/include/xorg/fb.h to this bug report?
Comment 3 Helge Oldach 2014-10-29 18:52:53 UTC
xorg-server-1.7.7_14,1
Comment 4 Helge Oldach 2014-10-29 18:56:15 UTC
Created attachment 148776 [details]
/usr/local/include/xorg/fb.h
Comment 5 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2014-10-29 19:04:54 UTC
We don't support xorg-server 1.7 anymore and xf86-video-intel 2.21.15 isn't compatible with it. You need to update xorg-server and probably other related ports.

The reasons for ending the support of xorg-server 1.7 and several other really old ports is explained in the following mail:
https://lists.freebsd.org/pipermail/freebsd-ports-announce/2014-October/000096.html

If you need help to proceed with the update, please ask your questions here :)
Comment 6 Helge Oldach 2014-10-29 19:13:33 UTC
Yes. However WITH_NEW_XORG has been removed from xf86-video-intel recently, but not from xorg-server. Therefore I (as a naïve user) would expect it to work still. Failing miserably during compilation with cryptic errors is not exactly self-explanatory.

Is there any particular reason for keeping WITH_NEW_XORG in xorg-server but removing it from drivers?
Comment 7 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2014-10-29 19:20:16 UTC
I think the maintainers wanted to remove the flag with the next updates to each ports. For instance, there's an update to xorg-server 1.14 cooking. This future update will remove the old WITH_NEW_XORG bits.
Comment 8 Koop Mast freebsd_committer freebsd_triage 2014-10-29 21:50:02 UTC
(In reply to Helge Oldach from comment #6)
> Yes. However WITH_NEW_XORG has been removed from xf86-video-intel recently,
> but not from xorg-server. Therefore I (as a naïve user) would expect it to
> work still. Failing miserably during compilation with cryptic errors is not
> exactly self-explanatory.
> 
> Is there any particular reason for keeping WITH_NEW_XORG in xorg-server but
> removing it from drivers?

Correct WITH_NEW_XORG was removed from xf86-video-intel but it has been turned on by default in https://svnweb.freebsd.org/changeset/ports/369875 unless WITHOUT_NEW_XORG was set. But the whole WITH_NEW_XORG switch is going away.

Which version of FreeBSD is this and do you maybe have WITHOUT_NEW_XORG set in /etc/make.conf?
Comment 9 Helge Oldach 2014-10-30 08:26:28 UTC
9-STABLE (built world about a week ago) - Yes, I know it does support KMS, and it should thus run the new xorg-server. Quite frankly I even tried that but was disappointed that it did build a huge amount of other ports (GCC and so on), and it resulted in garbage on my screen. So I dropped back again. Did not seem ready for prime time at that moment. (FWIW, this is an elder Q965-equipped machine.)

Indeed, /etc/make.conf has WITHOUT_NEW_XORG=yes. The old xorg-server has been doing fine for me up to now, so why change it... I was just struck that NEW_XORG is still in xorg-server while it has been removed from drivers, rendering them uncompilable.
Comment 10 Helge Oldach 2014-11-02 09:59:38 UTC
Fixed by removal of WTHOUT_NEW_XORG, forcing upgrading xorg-server to 1.12.