Bug 194713 - Overzealous directory cleanup by makeplist
Summary: Overzealous directory cleanup by makeplist
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-31 14:43 UTC by Michael Grünewald
Modified: 2015-01-22 08:39 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Grünewald 2014-10-31 14:43:17 UTC
The list of cleaned up directories prepared by _make makeplist_ is overzealous and contains a lot of directories which should not be listed here:

    @dir share/mk
    @dir share/texmf/tex/latex
    @dir share/texmf/tex
    @dir share/texmf

and maybe more depending on the port.


It is expected that:

1. make makeplist report a sensible list of directories to clean up.

2. portlint gives a hint that superfluous entries went into the list.

3. The Porter's handbook mentions a rule of thumb to decide which
   directories to clean and which not to clean.


Appropriate locations for 3 could be:

- https://www.freebsd.org/doc/en/books/porters-handbook/plist-cleaning.html
- https://www.freebsd.org/doc/en/books/porters-handbook/porting-dads.html
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2014-10-31 16:52:36 UTC
(In reply to Michael Grünewald from comment #0)
> 3. The Porter's handbook mentions a rule of thumb to decide which
>    directories to clean and which not to clean.

The porter's handbook doesn't give a rule of thumb, it gives an exact rule about which directories to put @dir entries for.

- Empty directories inside ${PREFIX}
- All directories outside ${PREFIX}

If it's not clear by reading [1] please tell me what I should do to make it more clear.

1: https://www.freebsd.org/doc/en/books/porters-handbook/plist-cleaning.html
Comment 2 Michael Grünewald 2014-11-01 11:04:47 UTC
The Porter's Handbook is actually crystal clear, only points 1 and 2 are
relevant.

(Just another victim of being unable to read a text when one believes
to know what is written there…)