Created attachment 148933 [details] Patch againts portlint/src/portlint.pl Running portlint -C on emulators/wine-devel, I get the following: WARN: Makefile: [0]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead. for pre-configure: cd ${WRKSRC} && ${TAR} xf ${DISTDIR}/${COMP_DIST} --strip-components 1 cd ${WRKSRC} && ${MAKE_CMD} -C ./patches DESTDIR=${WRKSRC} install The attached patch avoids this by preventing this warning when the string "install" appears at the end of a line, since that is definitely not the case we want to warn about. Alternately you could use "\${MAKE_CMD}.*install" as a pattern. If you approve, I can commit this myself (bumping the minor version).
Auto-assigned to maintainer marcus@FreeBSD.org
Yeah, I'd rather something like ${MAKE_CMD}.*\binstall\b to be safer. Using "install" by itself completely defeats the check we want here.
(In reply to Joe Marcus Clarke from comment #2) > Yeah, I'd rather something like ${MAKE_CMD}.*\binstall\b to be safer. Using > "install" by itself completely defeats the check we want here. Agreed on "install". Note that my patch has "install$" -- and the string "install" at the end of a line is not what we want to catch, is it?
Committed to my CVS repo pending the next release.
Fixed!