Bug 194763 - [patch] games/klavaro: restore -rdynamic flag
Summary: [patch] games/klavaro: restore -rdynamic flag
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2014-11-02 16:47 UTC by Andriy Voskoboinyk
Modified: 2014-12-02 21:53 UTC (History)
2 users (show)

See Also:
avos: maintainer-feedback? (herbert)

Attachments
patch-klavaro.diff (509 bytes, patch)
2014-11-02 16:47 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Update to version 3.01 (1.99 KB, patch)
2014-11-02 21:16 UTC, Herbert J. Skuhra 		no flags Details | Diff
Update to version 3.01 (5.30 KB, patch)
2014-12-02 15:35 UTC, Herbert J. Skuhra 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2014-11-02 16:47:59 UTC 
Created attachment 148937 [details]
patch-klavaro.diff

This will fix runtime errors ("Could not find signal handler").
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-02 16:47:59 UTC 
Maintainer CC'd
Comment 2 Herbert J. Skuhra 2014-11-02 21:16:42 UTC 
Created attachment 148962 [details]
Update to version 3.01

The attached patch updates the port to version 3.01 and adds '-rdynamic' to fix runtime.
Comment 3 Herbert J. Skuhra 2014-11-02 21:19:09 UTC 
Thanks. Please commit update to version 3.01. It includes Andriy's runtime fix.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-11-14 11:52:14 UTC 
Promote PR, maintainer provided a patch (and update), although he did not provide test logs.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-11-28 10:33:00 UTC 
I should not have let this go through without test logs.

===========================================================================
====> Running Q/A tests (stage-qa)
Warning: 'lib/libgtkdataboks.so.0' is not stripped consider trying INSTALL_TARGET=install-strip or using
Error: .la libraries found, port needs USES=libtool
*** Error code 1

Stop.
make: stopped in /usr/ports/games/klavaro


please fix both issues and resubmit.
Comment 6 Herbert J. Skuhra 2014-12-02 15:35:47 UTC 
Created attachment 150098 [details]
Update to version 3.01

Modified patch updates klavaro to version 3.01 and resolves issue with stage-qa and pkg-plist.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-12-02 21:51:50 UTC 
A commit references this bug:

Author: marino
Date: Tue Dec  2 21:51:43 UTC 2014
New revision: 373788
URL: https://svnweb.freebsd.org/changeset/ports/373788

Log:
  games/klavaro: Upgrade version 1.9.9 => 3.0.1

  The PR was a suggested fix, but the maintainer took the opportunity to
  update the game along with the suggested change.

  PR:		194763
  Opened by:	Andriy Voskoboinyk
  Upgraded by:	maintainer (Herbert Skuhra)

Changes:
  head/games/klavaro/Makefile
  head/games/klavaro/distinfo
  head/games/klavaro/pkg-plist
Comment 8 John Marino freebsd_committer freebsd_triage 2014-12-02 21:53:26 UTC 
Thanks Herbert, your second submission was good!