Bug 195021 - sysutils/munin-node: ntp_ and ntp_states plugins fail without dns/p5-Net-DNS
Summary: sysutils/munin-node: ntp_ and ntp_states plugins fail without dns/p5-Net-DNS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-14 23:48 UTC by John W. O'Brien
Modified: 2014-11-17 15:05 UTC (History)
2 users (show)

See Also:

Attachments
sysutils/munin-node: Depend upon dns/p5-Net-DNS at runtime (872 bytes, patch)
2014-11-14 23:48 UTC, John W. O'Brien 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John W. O'Brien 2014-11-14 23:48:37 UTC 
Created attachment 149421 [details]
sysutils/munin-node: Depend upon dns/p5-Net-DNS at runtime

sysutils/munin-node has an unstated runtime dependency on dns/p5-Net-DNS. There are two plugins that "use Net::DNS;", and they are ntp_ and ntp_states. Without the dependency installed the plugins fail as illustrated in this log excerpt:

    /var/log/munin/munin-node.log
    -----------------------------
    2014/11/14-00:00:06 [68072] Error output from ntp_states:
    2014/11/14-00:00:06 [68072]     Can't locate Net/DNS.pm in @INC (@INC contains: /usr/local/lib/perl5/5.16/BSDPAN /usr/local/lib/perl5/site_perl/5.16/mach /usr/local/lib/perl5/site_perl/5.16 /usr/local/lib/perl5/5.16/mach /usr/local/lib/perl5/5.16 .) at /usr/local/etc/munin/plugins/ntp_states line 43.
    2014/11/14-00:00:06 [68072]     BEGIN failed--compilation aborted at /usr/local/etc/munin/plugins/ntp_states line 43.
    2014/11/14-00:00:06 [68072] Service 'ntp_states' exited with status 2/0.

Fix:

Apply the attached patch to pick up the missing dependency.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-14 23:48:37 UTC 
Maintainers CC'd
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2014-11-17 14:02:24 UTC 
Yes, and Net-DNS is not the only module missing, varnish_ needs p5-XML-Parser, I've been meaning to go through all the Perl munin plugins for some time, now sounds like a good time :-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-11-17 15:04:41 UTC 
A commit references this bug:

Author: mat
Date: Mon Nov 17 15:04:23 UTC 2014
New revision: 372671
URL: https://svnweb.freebsd.org/changeset/ports/372671

Log:
  - Fix bugs in if_* (prompted by [1])
  - Add a new PERL option to add some extra dependencies needed by some modules
    (based on [2])

  PR:		194733 [1] 195021 [2]
  Submitted by:	Claudius Herder [1]  John W. O'Brien [2]
  Sponsored by:	Absolight

Changes:
  head/sysutils/munin-node/Makefile
  head/sysutils/munin-node/files/patch-node__munin-node.conf.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__if_.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__if_errcoll_.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__if_packets_.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__iostat.in
  head/sysutils/munin-node/files/patch-plugins__node.d__hddtemp_smartctl.in
  head/sysutils/munin-node/files/patch-plugins__node.d__multiping.in
  head/sysutils/munin-node/files/patch-plugins__node.d__squeezebox_.in
  head/sysutils/munin-node/pkg-plist