Bug 195095 - sysutils/fusefs-kmod fails to build
Summary: sysutils/fusefs-kmod fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2014-11-17 09:17 UTC by woot-woot
Modified: 2015-01-27 20:30 UTC (History)
4 users (show)

See Also:
dpejesh: maintainer-feedback+


Attachments
sysutils_fusefs-kmod.patch (3.85 KB, patch)
2014-12-02 16:46 UTC, evgeni.dimitrov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description woot-woot 2014-11-17 09:17:56 UTC
amd64 FreeBSD 9.3-STABLE #0 r274481

--->  Installing 'fusefs-kmod-0.263233,1' from a port (sysutils/fusefs-kmod)
--->  Building '/usr/ports/sysutils/fusefs-kmod'
===>  Cleaning for fusefs-kmod-0.263233,1
===>  Found saved configuration for fusefs-kmod-0.3.9.p1.20080208_11
===>   fusefs-kmod-0.263233,1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by fusefs-kmod-0.263233,1 for building
===>  Extracting for fusefs-kmod-0.263233,1
=> SHA256 Checksum OK for fusefs-kmod-0.263233.tar.gz.
===>  Patching for fusefs-kmod-0.263233,1
===>  Applying extra patch /usr/ports/sysutils/fusefs-kmod/files/extra-patch-9-fuse_vfsops.c
===>  Applying extra patch /usr/ports/sysutils/fusefs-kmod/files/extra-patch-9-fuse_vnops.c
===>  Applying FreeBSD patches for fusefs-kmod-0.263233,1
===>   fusefs-kmod-0.263233,1 depends on package: fusefs-libs>2.4.1 - found
===>  Configuring for fusefs-kmod-0.263233,1
===>  Building for fusefs-kmod-0.263233,1
cd /usr/ports/sysutils/fusefs-kmod/work/modules/fuse; make
Warning: Object directory not changed from original /usr/ports/sysutils/fusefs-kmod/work/modules/fuse
@ -> /usr/src/sys
machine -> /usr/src/sys/amd64/include
x86 -> /usr/src/sys/x86/include
awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -p
awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -q
awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -h
cc -O2 -pipe -march=core2 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999  -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option   -c /usr/ports/sysutils/fusefs-kmod/work/modules/fuse/../../fs/fuse/fuse_node.c
cc -O2 -pipe -march=core2 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999  -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option   -c /usr/ports/sysutils/fusefs-kmod/work/modules/fuse/../../fs/fuse/fuse_io.c
cc -O2 -pipe -march=core2 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999  -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option   -c /usr/ports/sysutils/fusefs-kmod/work/modules/fuse/../../fs/fuse/fuse_device.c
cc -O2 -pipe -march=core2 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999  -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option   -c /usr/ports/sysutils/fusefs-kmod/work/modules/fuse/../../fs/fuse/fuse_ipc.c
cc -O2 -pipe -march=core2 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999  -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option   -c /usr/ports/sysutils/fusefs-kmod/work/modules/fuse/../../fs/fuse/fuse_file.c
cc -O2 -pipe -march=core2 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999  -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option   -c /usr/ports/sysutils/fusefs-kmod/work/modules/fuse/../../fs/fuse/fuse_vfsops.c
/usr/ports/sysutils/fusefs-kmod/work/modules/fuse/../../fs/fuse/fuse_vfsops.c:116: error: invalid type argument of 'unary *' (have 'int')
/usr/ports/sysutils/fusefs-kmod/work/modules/fuse/../../fs/fuse/fuse_vfsops.c:120: error: size of array '__assert_1' is negative
*** [fuse_vfsops.o] Error code 1

Stop in /usr/ports/sysutils/fusefs-kmod/work/modules/fuse.
*** [do-build] Error code 1

Stop in /usr/ports/sysutils/fusefs-kmod.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-17 09:17:56 UTC
Maintainer CC'd
Comment 2 evgeni.dimitrov 2014-12-02 16:46:26 UTC
Created attachment 150099 [details]
sysutils_fusefs-kmod.patch

This port broke with r273912 [1] in base. A quick search in base/head revealed [2] and [3] which fix the port on 9-STABLE >= r273912. Unfortunately those patches break the port on 9-STABLE < r273912 and cannot be conditionally applied based on OSVERSION because it was not bumped with that revision. Taking that into account I modified the patches to conditionally compile the changes if the system supports it by checking if the new macros in <sys/sysctl.h> are defined. I also took the liberty of combining my changes with existing patches and updating the port's Makefile appropriately. The result is in the attached file.

[1] https://svnweb.freebsd.org/base?view=revision&revision=273912
[2] https://svnweb.freebsd.org/base/head/sys/fs/fuse/fuse_main.c?r1=241519&r2=273377&view=patch
[3] https://svnweb.freebsd.org/base/head/sys/fs/fuse/fuse_vfsops.c?r1=263233&r2=273377&view=patch
Comment 3 woot-woot 2014-12-07 06:46:56 UTC
Thanks for patch, works great.
Comment 4 dave 2015-01-25 14:12:06 UTC
This patch worked perfectly for me.  Could this please be merged into the ports tree?
Comment 5 John Marino freebsd_committer freebsd_triage 2015-01-25 17:48:57 UTC
The port has a new maintainer (the old one timed out a few times).  What does the maintainer say about all this?  (dpejesh@yahoo.com)
Comment 6 David Shane Holden 2015-01-26 12:53:39 UTC
Patch looks good.  Just need to bump the PORTREVISION on it.  Tested on 9.2 amd64/i386 and 9.3 amd64/i386.
Comment 7 John Marino freebsd_committer freebsd_triage 2015-01-26 13:07:06 UTC
promote to patch-ready status with a request to bump PORTREVISION.

Reviewed and approved by the maintainer.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-01-26 18:58:53 UTC
A commit references this bug:

Author: riggs
Date: Mon Jan 26 18:57:58 UTC 2015
New revision: 377941
URL: https://svnweb.freebsd.org/changeset/ports/377941

Log:
  Fix build failure on 9.x

  While on it:
  - Pet portlint

  PR:		195095
  Submitted by:	woot-woot@yandex.ru (PR) evgeni.dimitrov@gmail.com (patch)
  Reviewed by:	dpejesh@yahoo.com (maintainer)
  Approved by:	dpejesh@yahoo.com (maintainer)
  MFH:		2015Q1

Changes:
  head/sysutils/fusefs-kmod/Makefile
  head/sysutils/fusefs-kmod/files/extra-patch-9-fuse_main.c
  head/sysutils/fusefs-kmod/files/extra-patch-9-fuse_vfsops.c
  head/sysutils/fusefs-kmod/pkg-descr
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-01-27 20:30:11 UTC
A commit references this bug:

Author: riggs
Date: Tue Jan 27 20:29:20 UTC 2015
New revision: 378014
URL: https://svnweb.freebsd.org/changeset/ports/378014

Log:
  MFH: r377941

  Fix build failure on 9.x

  While on it:
  - Pet portlint

  PR:		195095
  Submitted by:	woot-woot@yandex.ru (PR) evgeni.dimitrov@gmail.com (patch)
  Reviewed by:	dpejesh@yahoo.com (maintainer)
  Approved by:	portmgr (mat), dpejesh@yahoo.com (maintainer)

Changes:
_U  branches/2015Q1/
  branches/2015Q1/sysutils/fusefs-kmod/Makefile
  branches/2015Q1/sysutils/fusefs-kmod/files/extra-patch-9-fuse_main.c
  branches/2015Q1/sysutils/fusefs-kmod/files/extra-patch-9-fuse_vfsops.c
  branches/2015Q1/sysutils/fusefs-kmod/pkg-descr