Bug 195117 - [maintainer update] ports-mgmt/portrac: Mark BROKEN on versions earlier than 10.
Summary: [maintainer update] ports-mgmt/portrac: Mark BROKEN on versions earlier than 10.
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-17 18:41 UTC by mario.g.pavlov
Modified: 2015-02-07 08:31 UTC (History)
2 users (show)

See Also:


Attachments
portrac-0.5.diff (478 bytes, patch)
2014-11-17 18:41 UTC, mario.g.pavlov
no flags Details | Diff
portrac-0.5.diff (501 bytes, patch)
2015-02-06 18:36 UTC, mario.g.pavlov
mario.g.pavlov: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mario.g.pavlov 2014-11-17 18:41:40 UTC
Created attachment 149528 [details]
portrac-0.5.diff

The port uses C++11 features and should be marked BROKEN on versions that don't have the new compiler infrastructure i.e. < 10.
Comment 1 Bartek Rutkowski freebsd_committer freebsd_triage 2014-12-02 13:08:32 UTC
Mario, wouldnt that port work if the compiler would be addes as a dependency from ports tree? Also, please note, that when using OS versions like that, you also need another confidion checking if the OS is FreeBSD - check other ports to see how its being done.
Comment 2 John Marino freebsd_committer freebsd_triage 2015-02-06 16:16:10 UTC
as Bartok said, this solution is wrong.
Please fix the port with USES=compiler 
refer to /usr/ports/Mk/Uses/compiler.mk for more details.
Closing the PR as invalid.
Comment 3 mario.g.pavlov 2015-02-06 18:36:20 UTC
Created attachment 152630 [details]
portrac-0.5.diff

Actually I just now saw that my update on this PR got lost due to the bugzilla maintenance issue. In my previous update I was explaining that this port uses not only the new compiler but other features from FreeBSD 10 as well such as the new pkg tool.
As a maintainer of the port and owner of the code I think it is best if the port stays as simple as possible and be supported only on FreeBSD 10 or later.
I'm aware that pkg-ng and the new compiler infrastructure can be used on earlier versions of FreeBSD but it's not worth the effort. Not to mention that the port uses QT5.
I'd like to ask you to re-open this PR and commit my patch which I also updated as per Bartek's proposal to add check for ${OPSYS}.
Thank you.
Comment 4 John Marino freebsd_committer freebsd_triage 2015-02-07 08:31:18 UTC
The premise that pkg is a FreeBSD 10 tool is wrong - I think you know that.
Secondly, pkg is not something that a port cares about.  They are independent.
Thirdly: We are telling you want the problem is.  You have to set USES=compiler.  Your response is "I can't figure that out, so let's just limit the port to the latest release".

We would prefer this port be fixed properly -- not limited because limited for artificial reasons.  There are good reasons for limiting a port to specific releases, but this isn't a good one IMO.

I also don't get the reference to QT5.
Obviously if the port requires QT5 and QT5 didn't build on FreeBSD9 (it does) then this port would get skipped due to a missing dependency, so no need to mask it specifically.

And this is a ports-mgmt tool!  That's are the last type of ports that should be limited.

Please set USES+= compiler:c++11-lib or whatever the callout is.  Bartek can check it with poudriere if you don't have that set up.  I don't see a persuasive argument to neglect supported FreeBSD releases here.